Improve search attribute extraction#321
Merged
johnweldon merged 2 commits intogo-ldap:masterfrom Aug 15, 2021
cpuschma:feature/attribute-perfomance
Merged
Improve search attribute extraction#321johnweldon merged 2 commits intogo-ldap:masterfrom cpuschma:feature/attribute-perfomance
johnweldon merged 2 commits intogo-ldap:masterfrom
cpuschma:feature/attribute-perfomance
Conversation
Member
Author
|
May someone please look into this? |
Member
Author
|
@johnweldon Is there a chance that this PR will be reviewed/merged? |
Member
😞 I'm sorry for neglecting this. I'll review shortly |
johnweldon
requested changes
Aug 15, 2021
Member
johnweldon
left a comment
johnweldon
left a comment
There was a problem hiding this comment.
LGTM; if you could address the minor whitespace issues, and rebase, I'll get this merged.
johnweldon
approved these changes
Aug 15, 2021
cpuschma
pushed a commit
to clementblaise/ldap
that referenced
this pull request
Apr 25, 2022
Co-authored-by: John Weldon <johnweldon4@gmail.com>
inv2004
pushed a commit
to inv2004/ldap
that referenced
this pull request
Jan 17, 2023
Co-authored-by: John Weldon <johnweldon4@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@stefanmcshane As mentioned in #319, here's my PR for improving the part of the attribute extraction after an LDAP search result has been returned by the server.
I did some benchmarks, as requested. The differences become more significant the more attributes are parsed. Regardless of the performance: I think this code should be moved into it's own fucnction anyway for better readability.