-
Notifications
You must be signed in to change notification settings - Fork 4
gomockの置き換え #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FlowingSPDG
wants to merge
1
commit into
go-generalize:master
Choose a base branch
from
FlowingSPDG:feature/gomock-uber
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
gomockの置き換え #256
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
既に
golang/mockをgo installしている人は、go generateした際にgolang/mock側が使われる可能性があるので、そこまで対策する場合//go:generate mockgen -source $GOFILE -destination mock/mock_history_gen/mock_history_gen.goを
//go:generate go run go.uber.org/mock/mockgen@latest -source $GOFILE -destination mock/mock_history_gen/mock_history_gen.goとするのも手かもしれません！
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
そうですね！
もしくは生成時のオプションで、golang/mock or uber/mockのパスを指定できるようにしてもいいかもですねGOBIN指定して./bin/などに入れている人もいるかもしれないので
uberの方強制でも良さそうですね
ファイルが大量にあることもあるので、毎回 go run させるのもな...と思ったりしてます！
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
そういえば、→ 使われていない...?mockgenのパス指定オプションは存在しますね 🤔https://github.com/go-generalize/volcago/blob/master/generator/generator.go#L57-L64なんとか
GOBINを指定することができれば、uberのものを矯正することも出来そうなので少し試してみます！There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
あ...すみません、その存在を忘れてました😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
お、折角であればこのPRでそのまま作業してしまおうかと思いますがいかがでしょう？
吐き出されるコードの
//go:generate mockgen -source $GOFILE -destination mock/mock_history_gen/mock_history_gen.goの
mockgenの部分をGenerateOption.MockGenPathに置き換える形で良いでしょうかね？(ただ、その場合、uber/mock 対応とはまた別の趣旨になってしまいますね... 🤔 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
大丈夫です！
よろしくお願いします🙏