Skip to content

Fix rm permission errors in local tests #1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meiji163 merged 2 commits into from
Mar 24, 2026
Merged

Fix rm permission errors in local tests #1644

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37fd87d
Fix local tests by making .gopath writable to avoid toolchain rm perm…
grodowski Mar 11, 2026
4d12d1b
Merge branch 'master' into fix-dev-test
grodowski Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions script/bootstrap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@ set -e
# up so it points back to us and go is none the wiser

set -x
rm -rf .gopath
mkdir -p .gopath/src/github.com/github
ln -s "$PWD" .gopath/src/github.com/github/gh-ost
if [ ! -L .gopath/src/github.com/github/gh-ost ]; then
rm -rf .gopath
mkdir -p .gopath/src/github.com/github
ln -s "$PWD" .gopath/src/github.com/github/gh-ost
fi
Comment on lines +14 to +18
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The guard only checks that .gopath/src/github.com/github/gh-ost is a symlink (-L). If the repo is moved/renamed, an existing symlink can become stale (or point at a different checkout) and this block will be skipped, causing script/test/script/go to cd into the wrong/broken location. Consider also verifying the symlink target matches the current repo path (e.g., compare readlink to $PWD and/or ensure the link target exists) and recreate .gopath when it doesn't.

Copilot uses AI. Check for mistakes.
export GOPATH=$PWD/.gopath:$GOPATH
Loading