(#17) updated TargetFramework to net6.0-windows7.0#18
(#17) updated TargetFramework to net6.0-windows7.0#18nils-a wants to merge 2 commits intogitextensions:masterfrom
Conversation
* Bumped GitExtensions.Extensibility * Referenced Microsoft.VisualStudio.Composition * Referenced Microsoft.VisualStudio.threading
| <PackageReference Include="Microsoft.VisualStudio.Composition" Version="17.4.16" /> | ||
| <PackageReference Include="Microsoft.VisualStudio.threading" Version="17.5.22" /> |
There was a problem hiding this comment.
In Plugin Manager we have System.ComponentModel.Composition with 6.0.0 and that's enough. I think we had some problems when referencing VS MEF in Plugin Manager.
There was a problem hiding this comment.
That's a good point. We can only use versions used in the main app: https://github.com/gitextensions/gitextensions/blob/master/Packages.props#L18-L20
But since we'd be referencing the main app, I'm curious why we need these here.
There was a problem hiding this comment.
Hm, we just reference main app specific dlls. It doesn't add indirect references to the build, right? And so we need some MEF to be able compile the plugin dll.
Maybe could add all/some package reference from main app to the GitExtensions.Extensibility
There was a problem hiding this comment.
I "only" copied those from the Gerrit plugin. I was wondering, though, why it was those instead of System.ComponentModel.Composition.
I'm perfectly happy to change those for something better. Referencing Microsoft.VisualStudio.* feels weird.
There was a problem hiding this comment.
I would remove these completely unless we have a strong justification. In case we do, we should document it here.
| <PackageReference Include="Microsoft.VisualStudio.Composition" Version="17.4.16" /> | ||
| <PackageReference Include="Microsoft.VisualStudio.threading" Version="17.5.22" /> |
There was a problem hiding this comment.
In Plugin Manager we have System.ComponentModel.Composition with 6.0.0 and that's enough. I think we had some problems when referencing VS MEF in Plugin Manager.
| <!-- path is relative to $(ProjectDir) --> | ||
| <GitExtensionsDownloadPath>..\..\..\gitextensions.shared</GitExtensionsDownloadPath> | ||
| <!-- 'latest' or 'v3.1' (= tag from GitHub releases) or 'v3.1.0.5877' (= build number from AppVeyor)--> | ||
| <GitExtensionsReferenceVersion>latest</GitExtensionsReferenceVersion> |
There was a problem hiding this comment.
It would be good to add a section to readme under Good Practices stating that GitExtensionsReferenceVersion used for local development should be synchronized with GitExtensions.Extensibility package version, so local dev loop and published package targets the same version of Git Extensions.
It's out of scope of this PR, so if you don't want to write it, I can do it in a separate PR
There was a problem hiding this comment.
I'm not so good on words, but I'll give it a try.
I'm uncertain if I get what you mean, here.
GitExtensions.Extensibility "only" ensures a local copy of Git Extensions exists for local development. It "only" provides the preBuild and the postBuild targets, does it not?
There was a problem hiding this comment.
It also adds a dependency in the built nuget package and we use this dependency to validate that the package is intended for the current main app version (we still have gaps in this area, but in general 0.3 means targeting Git Extensions v4).
As we don't have a stable API yet, you typically need to "hack" into what Git Extensions give you in the current plugin API, and so it is important to build against "similar" version that you the plugin to run in (most of my plugins needs at least recompilation between main app version upgrades).
Using "latest" can be dangerous, because it may download even preview version.
* TargetFramework is now `net6.0-windows` * Removed package references to Microsoft.VisualStudio.Composition & Microsoft.VisualStudio.Threading * added a reference to the System.ComponentModel.Composition.dll that is provided by Git Extensions Also, I bumped the AppVeyor image to VS2022 to get support for net6.0.
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>net461</TargetFramework> | ||
| <TargetFramework>net6.0-windows</TargetFramework> |
There was a problem hiding this comment.
| <TargetFramework>net6.0-windows</TargetFramework> | |
| <TargetFramework>net10.0-windows</TargetFramework> |
| <Reference Include="System.ComponentModel.Composition"> | ||
| <HintPath>$(GitExtensionsPath)\System.ComponentModel.Composition.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="System.Windows.Forms, Version=6.0.*" /> |
There was a problem hiding this comment.
| <Reference Include="System.Windows.Forms, Version=6.0.*" /> | |
| <Reference Include="System.Windows.Forms, Version=10.0.*" /> |
Is this needed?
4 participants
fixes #17
fixes #16