updated the package to work with the new sfit4 1.0.18 - #2
Open
makkorjamal wants to merge 2 commits into
Open
Conversation
Member
|
Thanks @makkorjamal for looking into this, and sorry for the wait (please note: I'm not actively maintaining this repository anymore). I guess the changes made here break compatibility with old versions of SFIT4? If so, would it be possible to make it compatible with both versions so that it is still possible to use this library for loading old outputs? |
Author
|
@benbovy Yes that's true I will try to fix the compatibility with older SFIT4 versions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sfit4 was recently updated and the headers were changed.
So the code does not work anymore.
I updated the regex header to work with the new version