remove no-effect HWLOC stuff - #2060
Merged
Merged
Conversation
yhmtsai
added
the
is:interface-breaking
ginkgo-bot
added
reg:build
MarcelKoch
requested changes
Aug 5, 2026
MarcelKoch
left a comment
MarcelKoch
left a comment
Member
There was a problem hiding this comment.
LGTM. I think it should also be mentioned in the interface break doc.
MarcelKoch
approved these changes
Aug 5, 2026
yhmtsai
added
1:ST:ready-to-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the HWLOC usage in Ginkgo, which has been mentioned no-effect in #1513
It changes
num_computing_unitsto 1 for Reference but omp_get_max_threads for Omp.num_pu_per_cu is 1 for both cases.
It removes the machine_topology and the corresponding interfaces in Executor.
In future, if we need to bring this back to Ginkgo, binding to cores might have issues when assigning partial cores from slurm.