fix(dx12): Map components properly for textureLoad from stencil#9520
Open
andyleiserson wants to merge 3 commits intogfx-rs:trunkfrom
Open
fix(dx12): Map components properly for textureLoad from stencil#9520andyleiserson wants to merge 3 commits intogfx-rs:trunkfrom
andyleiserson wants to merge 3 commits intogfx-rs:trunkfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shader view format used by the dx12 backend for stencil-only views,
DXGI_FORMAT_X24_TYPELESS_G8_UINT, places the value in the green component. WebGPU requires it in the red component.Fixes #6620 using the approach suggested by the reporter: configure a
D3D12_SHADER_COMPONENT_MAPPINGswizzle in the view.Testing
Enables CTS tests (it's not clear that this coverage is the primary goal of these CTS tests, but I couldn't find anything better, and coverage is coverage). This change fixes the two
format="stencil8"tests; it also adds other tests that were already passing totest.lst, and other pre-existing failures tofail.lst.Squash or Rebase? Squash
Checklist
wgpumay be affected behaviorally.CHANGELOG.mdentries for the user-facing effects of this change are present.