Skip to content

test(cts): Move some config from actions yaml to xtask #9519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andyleiserson wants to merge 2 commits into
base: trunk
Choose a base branch
from
+16 −2
Open

test(cts): Move some config from actions yaml to xtask #9519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0da671
test(cts): Move some config from actions yaml to xtask
andyleiserson May 5, 2026
dcbba45
restore necessary env setting
andyleiserson May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/cts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ env:
REPO_MSRV: "1.93"
CARGO_INCREMENTAL: false
CARGO_TERM_COLOR: always
DENO_WEBGPU_DX12_COMPILER: dynamicdxc
RUST_BACKTRACE: full
RUSTFLAGS: -D warnings
RUSTDOCFLAGS: -D warnings
Expand Down
17 changes: 16 additions & 1 deletion xtask/src/cts.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,11 +137,26 @@ pub fn run_cts(
})
.collect::<Vec<_>>();

if running_on_backend.is_none() && (!list_files.is_empty() || tests.is_empty()) {
if let Some(backend) = &running_on_backend {
shell.set_var("DENO_WEBGPU_BACKEND", backend);
} else if !list_files.is_empty() || tests.is_empty() {
log::warn!("The `--backend` option was not provided. `fails-if` conditions and external");
log::warn!("texture support are handled correctly only when a backend is specified.");
}

#[cfg(windows)]
if running_on_backend.as_ref().is_none_or(|b| b == "dx12") {
const DEFAULT_DX12_COMPILER: &str = "dynamicdxc";

match shell.var("DENO_WEBGPU_DX12_COMPILER") {
Ok(value) => log::info!("Using DENO_WEBGPU_DX12_COMPILER = {value} from environment"),
Err(_) => {
shell.set_var("DENO_WEBGPU_DX12_COMPILER", DEFAULT_DX12_COMPILER);
log::info!("Using default DENO_WEBGPU_DX12_COMPILER = {DEFAULT_DX12_COMPILER}");
}
}
}

let mut default_output_filter = PrintOutputWhen::Always;

if tests.is_empty() && list_files.is_empty() {
Expand Down
Loading