Skip to content

[hlsl] more matCx2 fixes#9507

Merged
teoxoy merged 3 commits intogfx-rs:trunkfrom
teoxoy:mat-c-2
May 7, 2026
Merged

[hlsl] more matCx2 fixes#9507
teoxoy merged 3 commits intogfx-rs:trunkfrom
teoxoy:mat-c-2

Conversation

@teoxoy
Copy link
Copy Markdown
Member

@teoxoy teoxoy commented May 5, 2026

Connections
-

Description
See commits.

Testing
Added more snapshots.

Squash or Rebase?
Rebase

Copy link
Copy Markdown
Contributor

@andyleiserson andyleiserson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a new issue with this change, and it doesn't need to block merging, but it looks like we're missing the reserved names for this stuff in keywords.rs.

This might be worth a CHANGELOG mention.

@teoxoy
Copy link
Copy Markdown
Member Author

teoxoy commented May 6, 2026

WGSL and GLSL (our two text frontends) don't allow identifiers to start with __ so I thought that's ok but I guess it would be clearer to add them to the namer?

@andyleiserson
Copy link
Copy Markdown
Contributor

WGSL and GLSL (our two text frontends) don't allow identifiers to start with __ so I thought that's ok but I guess it would be clearer to add them to the namer?

I'm not sure if it's a small or large portion of the instances that exist, but there are at least some naga-defined __ identifiers in the keywords file. It does seem useful to have an inventory somewhere of names that naga uses, even if we don't explicitly check for conflicts with user identifiers. Possibly we should reject __ in the validator as well? I'll file an issue.

@teoxoy teoxoy merged commit 04a7fe8 into gfx-rs:trunk May 7, 2026
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants