fix(gles): Tidy locking in struct Buffer#9505
Open
andyleiserson wants to merge 1 commit intogfx-rs:trunkfrom
Open
fix(gles): Tidy locking in struct Buffer#9505andyleiserson wants to merge 1 commit intogfx-rs:trunkfrom
struct Buffer#9505andyleiserson wants to merge 1 commit intogfx-rs:trunkfrom
Conversation
andyleiserson
commented
May 5, 2026
| struct BufferMapState { | ||
| /// True if the GL buffer is actually mapped, i.e. not "fake-mapped" with | ||
| /// an empty slice | ||
| mapped: Cell<bool>, |
Contributor
Author
There was a problem hiding this comment.
This is the key piece in all of this. Cell is not Sync and should not be used here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue with #8505.
Rather than use multiple adjacent mutexes and try to reason about protecting access to
mapped: Cell<bool>with the GL context lock, puts all of the map state together under a single mutex, and removes the unsafeSend/Syncforstruct Buffer.Testing
Existing tests and keeping the compiler happy.
Squash or Rebase? Squash
Checklist
wgpumay be affected behaviorally.CHANGELOG.mdentries for the user-facing effects of this change are present.