Skip to content

fix(core): Check for device loss on all submit paths#9478

Merged
teoxoy merged 1 commit intogfx-rs:trunkfrom
andyleiserson:jj-push-qovq
May 6, 2026
Merged

fix(core): Check for device loss on all submit paths#9478
teoxoy merged 1 commit intogfx-rs:trunkfrom
andyleiserson:jj-push-qovq

Conversation

@andyleiserson
Copy link
Copy Markdown
Contributor

@andyleiserson andyleiserson commented May 1, 2026

Small follow-up to #9307. Moves the check for device loss from Queue::submit to the common submit API, so that it applies to all the submit paths. (map_async has it's own check, so it's on_submitted_work_done and prepare_surface_texture_for_present where this is more likely to matter.)

Testing
Not directly tested.

Squash or Rebase? Squash

Checklist

  • I self-reviewed and fully understand this PR.
  • WebGPU implementations built with wgpu may be affected behaviorally.
  • Validation and feature gates are in place to confine behavioral changes.
  • Tests demonstrate the validation and altered logic works.
  • CHANGELOG.md entries for the user-facing effects of this change are present.
    • All of the affected codepaths are new since the last release and already noted in the CHANGELOG.
  • The PR is minimal, and doesn't make sense to land as multiple PRs.
  • Commits are logically scoped and individually reviewable.
  • The PR description has enough context to understand the motivation and solution implemented.

Fix a hypothetical race condition in `Device::maintain`
Copy link
Copy Markdown
Collaborator

@inner-daemons inner-daemons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM at a cursory glance

@teoxoy teoxoy merged commit 54bf53e into gfx-rs:trunk May 6, 2026
58 checks passed
@andyleiserson andyleiserson deleted the jj-push-qovq branch May 6, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants