fix(core): Check for device loss on all submit paths#9478
Merged
teoxoy merged 1 commit intogfx-rs:trunkfrom May 6, 2026
Merged
fix(core): Check for device loss on all submit paths#9478teoxoy merged 1 commit intogfx-rs:trunkfrom
teoxoy merged 1 commit intogfx-rs:trunkfrom
Conversation
Fix a hypothetical race condition in `Device::maintain`
inner-daemons
approved these changes
May 6, 2026
Collaborator
inner-daemons
left a comment
There was a problem hiding this comment.
LGTM at a cursory glance
teoxoy
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-up to #9307. Moves the check for device loss from
Queue::submitto the common submit API, so that it applies to all the submit paths. (map_asynchas it's own check, so it'son_submitted_work_doneandprepare_surface_texture_for_presentwhere this is more likely to matter.)Testing
Not directly tested.
Squash or Rebase? Squash
Checklist
wgpumay be affected behaviorally.CHANGELOG.mdentries for the user-facing effects of this change are present.