refactor(core): Eliminate buffer mapping logic in Global#9444
Merged
teoxoy merged 1 commit intogfx-rs:trunkfrom Apr 21, 2026
Merged
refactor(core): Eliminate buffer mapping logic in Global#9444teoxoy merged 1 commit intogfx-rs:trunkfrom
Global#9444teoxoy merged 1 commit intogfx-rs:trunkfrom
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small refactor relevant to and in preparation for #9307.
Motivations:
Globalto be looking up objects in the hub, and expect it will go away once Remove IDs and Registries #5121 is resolved, so functional logic should move elsewhere.map_async, which is able to call the callback after locks are released: "Returns the mapping callback in case of error so that the callback can be fired outside of the locks that are held in this function."Testing
Existing tests
Squash or Rebase? Squash
Checklist
wgpumay be affected behaviorally.CHANGELOG.mdentries for the user-facing effects of this change are present.