fix(eventstore): Handle Group.DoesNotExist in Event.group property#115253
Draft
sentry[bot] wants to merge 1 commit intomasterfrom
Draft
fix(eventstore): Handle Group.DoesNotExist in Event.group property#115253sentry[bot] wants to merge 1 commit intomasterfrom
sentry[bot] wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root cause was identified in
src/sentry/services/eventstore/models.pywithin theEvent.groupproperty. The property directly callsGroup.objects.get(id=self.group_id)without any exception handling. If the referencedGroupobject had been deleted or was not yet replicated, this call would raiseGroup.DoesNotExist, bubbling up and crashing the request.The solution implemented wraps the
Group.objects.get()call in atry-except Group.DoesNotExistblock. If theGroupis not found,Noneis returned and cached for subsequent accesses. This aligns the behavior with cases whereself.group_idisNone, ensuring that a missing group is gracefully handled without raising an exception. This makes theEvent.groupproperty more robust and prevents unexpected 500 errors.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes SENTRY-3ZZB