ref(projects): Convert deprecated project redirect to hooks#115249
Open
ref(projects): Convert deprecated project redirect to hooks#115249
Conversation
The legacy redirect route still used a class wrapper and api.requestPromise. Use the shared detailed project query so it shares cache behavior and keeps the collapse option in one place. Adds tests for the redirect and 404 cases. Co-Authored-By: Codex GPT-5 <noreply@openai.com>
github-actions
Bot
added
the
Scope: Frontend
Avoid casting the query error just to check for a 404. RequestError is a real class, so use instanceof and let TypeScript narrow it. Co-Authored-By: Codex GPT-5 <noreply@openai.com>
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.46% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deprecated project redirect route still had a class wrapper doing its own API request. This switches it over to useDetailedProject so it shares the detailed project query cache and keeps collapse=organization behavior in one place.
Adds coverage for the successful redirect path and the project 404 state.