fix(members): Validate teamRoles entries have required keys#115247
Draft
fix(members): Validate teamRoles entries have required keys#115247
Conversation
The teamRoles field is a ListField of JSONField, so individual items were not validated. Indexing item["role"] / item["teamSlug"] in validate_teamRoles raised KeyError -> 500 when callers sent malformed entries. Reject entries that aren't dicts containing both keys with a ValidationError so the response is a 400 instead. Fixes SENTRY-52BQ Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The teamRoles field is a ListField of JSONField, so individual items were not validated. Indexing item["role"] / item["teamSlug"] in validate_teamRoles raised KeyError -> 500 when callers sent malformed entries. Reject entries that aren't dicts containing both keys with a ValidationError so the response is a 400 instead.
Fixes SENTRY-52BQ