Skip to content

chore(codeowners): clean up#115237

Open
sentaur-athena wants to merge 1 commit intomasterfrom
athena/codeowner-update
Open

chore(codeowners): clean up#115237
sentaur-athena wants to merge 1 commit intomasterfrom
athena/codeowner-update

Conversation

@sentaur-athena
Copy link
Copy Markdown
Member

Part of https://linear.app/getsentry/issue/ISWF-2308/product-level-codeowners 🧼

Killing multiple non-existing old teams: ecosystem, enterprise, integrations, alert-notifications
Splitting integrations by type: project management, coding, messaging, others
Clarify unowned areas under "foundations" potentially to be reviewed by future product platform team

@sentaur-athena sentaur-athena requested review from a team as code owners May 8, 2026 22:11
@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 8, 2026

ISWF-2308

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label May 8, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 797c934. Configure here.

Comment thread .github/CODEOWNERS
/src/sentry/integrations/perforce/ @getsentry/product-owners-settings-integrations @getsentry/ecosystem @getsentry/scm @getsentry/gdx
/src/sentry/integrations/source_code_management/ @getsentry/coding-workflows-sentry-backend @getsentry/scm
/src/sentry/integrations/repository/ @getsentry/scm
/src/sentry/integrations/github_foundations/ @getsentry/scm
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CODEOWNERS path references non-existent directory name

High Severity

The path /src/sentry/integrations/github_foundations/ does not exist — the actual directory is github_enterprise/. This appears to be an accidental rename of the directory path (possibly confusing the team name foundations with the directory name). The corresponding test path on line 895 correctly uses github_enterprise/. As a result, the @getsentry/scm team won't be assigned as code owners for files in src/sentry/integrations/github_enterprise/.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 797c934. Configure here.

Comment thread .github/CODEOWNERS
/src/sentry/integrations/discord/* @getsentry/messaging-integrations
/tests/sentry/integrations/slack/* @getsentry/messaging-integrations
/tests/sentry/integrations/msteams/* @getsentry/messaging-integrations
/tests/sentry/integrations/discord/* @getsentry/messaging-integrations
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glob pattern /* won't match subdirectory files

High Severity

The new messaging and project management integration rules use /* (e.g., /src/sentry/integrations/slack/*), which in CODEOWNERS only matches files directly in that directory, not files in subdirectories. These integration directories all contain nested subdirectories like webhooks/, actions/, handlers/, etc. Files in those subdirectories won't be matched, so the intended teams won't be requested for review. The trailing / (without *) or /** would match recursively.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 797c934. Configure here.

Copy link
Copy Markdown
Member

@ceorourke ceorourke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for the alerts-notifications & alerts-create-issues -> alerts-monitors portion of it. I imagine other teams may want to give their approval on the things being reassigned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants