fix: Remove AGP 7.x R8 workaround#1222
Open
runningcode wants to merge 2 commits into
Open
Conversation
runningcode
requested review from
adinauer,
chromy,
markushi,
rbro112 and
romtsn
as code owners
AGP 7.x is no longer in the CI matrix and the default AGP version is 8.10.1. The conditional R8 classpath override is dead code. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
romtsn
force-pushed
the
no/remove-agp7-r8-workaround
branch
from
f5b80a8 to
7fc3951
Compare
romtsn
approved these changes
Jun 12, 2026
romtsn
left a comment
romtsn
left a comment
Member
There was a problem hiding this comment.
I guess it's fine to not test compat with 7.x.x -- checked the usage and there's overall around ~500 AGP 7.x.x users (out of those who opted in for telemetry). We should drop it in the next major and it's fine to accept the risk of breaking something for the small number of users for now, imo (it's like 1.5% of overall).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build.gradle.ktsand the test template inBaseSentryPluginTest.kt#skip-changelog
🤖 Generated with Claude Code