Fix simulator session argument overrides - #512
Open
vsolano9 wants to merge 3 commits into
Open
Conversation
vsolano9
marked this pull request as ready for review
August 18, 2026 20:42
Lock the MCP regression for concurrent worktrees: an explicit test_sim project, scheme, configuration, and simulator override session defaults while typed test selectors reach the test-without-building phase.
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7198979. Configure here.
Give the stored session default a different UUID from the explicit simulator-name resolution so both the positive and negative command assertions prove destination precedence. Addresses review feedback on PR getsentry#512.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changed
onlyTestingandskipTestinginputs totest_simRoot cause
The session-aware handler already merged explicit arguments after defaults, but the public simulator schemas omitted every default-backed field. MCP validation therefore removed explicit project, scheme, destination, and configuration values before they reached that merge.
Validation
npm run format:checknpm run lint(0 errors; existing warnings only)npm run typechecknpm run buildnpm run test:smoke(123 passed; earlier branch validation)npm run test:schema-fixtures(333 passed; earlier branch validation)The full
npm testrun passed 2,588 of 2,591 tests. Three unrelated baseline tests failed inconfig-store.test.tsandpurge-ui.test.ts; none exercise files changed here.Fixes #509.
Fixes #517.
AI assistance: Codex helped reproduce the MCP schema boundary failure, implement the fix, and run validation. The resulting diff and test output were reviewed before submission.