Skip to content

Fix simulator session argument overrides - #512

Open
vsolano9 wants to merge 3 commits into
getsentry:mainfrom
vsolano9:codex/fix-509-simulator-argument-precedence
Open

Fix simulator session argument overrides#512
vsolano9 wants to merge 3 commits into
getsentry:mainfrom
vsolano9:codex/fix-509-simulator-argument-precedence

Conversation

@vsolano9

@vsolano9 vsolano9 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

What changed

  • expose session-backed simulator build, build-and-run, and test inputs in the MCP schemas so explicit call arguments can override stored defaults
  • add typed onlyTesting and skipTesting inputs to test_sim
  • cover the MCP boundary with end-to-end regression tests, including a concurrent-worktree case where explicit test source and destination values override a different session default while selectors survive both test phases
  • refresh the public schema fixtures

Root cause

The session-aware handler already merged explicit arguments after defaults, but the public simulator schemas omitted every default-backed field. MCP validation therefore removed explicit project, scheme, destination, and configuration values before they reached that merge.

Validation

  • npm run format:check
  • npm run lint (0 errors; existing warnings only)
  • npm run typecheck
  • npm run build
  • focused concurrent-worktree regression (20 consecutive passes)
  • MCP session end-to-end file (9 passed)
  • npm run test:smoke (123 passed; earlier branch validation)
  • npm run test:schema-fixtures (333 passed; earlier branch validation)
  • focused simulator tests (52 passed; earlier branch validation)
  • MCP session end-to-end tests (9 passed)

The full npm test run passed 2,588 of 2,591 tests. Three unrelated baseline tests failed in config-store.test.ts and purge-ui.test.ts; none exercise files changed here.

Fixes #509.
Fixes #517.

AI assistance: Codex helped reproduce the MCP schema boundary failure, implement the fix, and run validation. The resulting diff and test output were reviewed before submission.

@vsolano9
vsolano9 marked this pull request as ready for review August 18, 2026 20:42
Lock the MCP regression for concurrent worktrees: an explicit test_sim project, scheme, configuration, and simulator override session defaults while typed test selectors reach the test-without-building phase.

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7198979. Configure here.

Comment thread src/smoke-tests/__tests__/e2e-mcp-sessions.test.ts
Give the stored session default a different UUID from the explicit simulator-name resolution so both the positive and negative command assertions prove destination precedence.

Addresses review feedback on PR getsentry#512.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant