deps: bump keepcurrent to pick up FromTarGz extraction fix#245
Merged
myleshorton merged 1 commit intomainfrom Apr 22, 2026
Merged
deps: bump keepcurrent to pick up FromTarGz extraction fix#245myleshorton merged 1 commit intomainfrom
myleshorton merged 1 commit intomainfrom
Conversation
Bumps keepcurrent from 017d542 (2026-03-04) to 54a4d9a (2026-04-22). Pulls in getlantern/keepcurrent#7, which fixes two back-to-back bugs in FromTarGz introduced by the mholt/archiver → mholt/archives migration: 1. archives.CompressedArchive was constructed with Archival set instead of Extraction, so Extract() returned "no extraction format" on every call — silently swallowed by the keepcurrent retry loop. 2. NameInArchive comparison was against the full stored path, but callers (here) pass a basename. MaxMind ships the mmdb under a dated directory (GeoLite2-City_YYYYMMDD/GeoLite2-City.mmdb) so the basename compare (path.Base) is the right behavior, matching the prior archiver/v3 implementation. Downstream effect: every bandit VPS was silently failing to load the GeoIP database, so tracker/metrics tagged every proxy.io data point with geo.country.iso_code="" and the dashboard's country filter matched zero. Once this lands and the packer image is rebuilt + rolled out, country tagging should start working on fresh VPSes.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the github.com/getlantern/keepcurrent dependency to a newer pseudo-version in order to pick up upstream fixes to tar.gz extraction behavior (used downstream for MaxMind GeoIP DB retrieval).
Changes:
- Bump
github.com/getlantern/keepcurrentfrom017d542to54a4d9aingo.mod - Update corresponding
go.sumentries for the new pseudo-version
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Updates the keepcurrent indirect requirement to the newer pseudo-version containing the extraction fixes. |
| go.sum | Refreshes checksums to match the updated keepcurrent pseudo-version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps `github.com/getlantern/keepcurrent` from `017d542` (2026-03-04) to `54a4d9a` (2026-04-22), pulling in getlantern/keepcurrent#7.
Why
Every bandit VPS has been silently failing to load the MaxMind GeoIP2-City database since the mholt/archiver → mholt/archives migration in keepcurrent. The downstream effect is that `tracker/metrics/tracker.go` tagged every `proxy.io` data point with `geo.country.iso_code=""` (because `*lookup.CountryCode` returns empty when the db never loads), and the dashboard's country filter matched zero across the entire fleet.
Two bugs fixed upstream:
Verified end-to-end
Before shipping upstream #7, ran a minimal Go probe against a live production bandit VPS reproducing the exact `keepcurrent.FromTarGz(FromWeb(url), "GeoLite2-City.mmdb").Fetch()` call path. Pre-fix: `err="no extraction format"`. Post-fix: extracts the 63 MB mmdb in 1.6 s.
Next
Test plan