Inverted FK direction from Resource to StoredData to fix N+1 on resource search list. - #577
Merged
Conversation
axl8713
force-pushed
the
fix-resource-data-n+1
branch
from
July 9, 2026 11:28
31cb382 to
5824552
Compare
Contributor
Author
|
@offtherailz How to name the SQL migration scripts? Should they reflect an older version? |
axl8713
marked this pull request as draft
July 9, 2026 12:15
axl8713
force-pushed
the
fix-resource-data-n+1
branch
from
July 9, 2026 12:26
5824552 to
aa4eb8f
Compare
axl8713
marked this pull request as ready for review
July 9, 2026 12:26
tdipisa
marked this pull request as draft
July 9, 2026 14:45
tdipisa
marked this pull request as ready for review
July 9, 2026 14:45
Member
|
@axl8713 please let's wait 2.6.0 to be released before merging the backport of this one. |
afabiani
approved these changes
Aug 3, 2026
Contributor
Author
|
@tdipisa Waiting confirmation about migration scripts version numbers before merging. |
Member
@axl8713 the following is fine as it follows the same naming convention followed so far.
going to merge... @axl8713 please create an issue to connect to this PR for tests. |
Member
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-577-to-2.6.x
git worktree add --checkout .worktree/backport-577-to-2.6.x backport-577-to-2.6.x
cd .worktree/backport-577-to-2.6.x
git reset --hard HEAD^
git cherry-pick -x 34f33a807e280dcbc75bca39ea955876b234dbc4
git push --force-with-lease |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes address the issue reported here, where a N+1 problem emerged when listing Resources; all the StoredData associated with Resources were loaded even with
includeData=false, causing a performance drop for long lists of resources.