Skip to content

[CMake] Change C++ version to 17#119

Merged
bodhinandach merged 2 commits into
masterfrom
c++/version_update
Apr 23, 2026
Merged

[CMake] Change C++ version to 17#119
bodhinandach merged 2 commits into
masterfrom
c++/version_update

Conversation

@bodhinandach
Copy link
Copy Markdown
Member

Describe the PR
This PR changes the default version of C++ from 13 to 17. This allows us to use a little bit of the newer capabilities of C++.

Related Issues/PRs
Initiated as it becomes useful in #116

Additional context
N/A

@bodhinandach bodhinandach added the enhancement New feature or request label Apr 14, 2026
@bodhinandach bodhinandach assigned bodhinandach and unassigned cgeudeker and Curiim Apr 14, 2026
@bodhinandach bodhinandach marked this pull request as ready for review April 14, 2026 21:49
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.78%. Comparing base (bcaa78a) to head (26f1e52).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
- Coverage   95.79%   95.78%   -0.01%     
==========================================
  Files         244      244              
  Lines       51738    51680      -58     
==========================================
- Hits        49559    49499      -60     
- Misses       2179     2181       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cgeudeker
Copy link
Copy Markdown
Collaborator

Looks good to me. Before approving I just wanted to ask/check if it would be worth using a more updated C++ version (i.e. 20 or 23)? Or will that require too much refactoring/create compatibility issues with packages being used?

@bodhinandach
Copy link
Copy Markdown
Member Author

Let's try with 17 first for now. I read the other time that v20 and v23 require some refactoring.

Copy link
Copy Markdown
Collaborator

@cgeudeker cgeudeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@bodhinandach bodhinandach merged commit bbd4194 into master Apr 23, 2026
7 of 8 checks passed
@bodhinandach bodhinandach deleted the c++/version_update branch April 23, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants