[CMake] Change C++ version to 17#119
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #119 +/- ##
==========================================
- Coverage 95.79% 95.78% -0.01%
==========================================
Files 244 244
Lines 51738 51680 -58
==========================================
- Hits 49559 49499 -60
- Misses 2179 2181 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Looks good to me. Before approving I just wanted to ask/check if it would be worth using a more updated C++ version (i.e. 20 or 23)? Or will that require too much refactoring/create compatibility issues with packages being used? |
Member
Author
|
Let's try with 17 first for now. I read the other time that v20 and v23 require some refactoring. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
This PR changes the default version of C++ from 13 to 17. This allows us to use a little bit of the newer capabilities of C++.
Related Issues/PRs
Initiated as it becomes useful in #116
Additional context
N/A