fix(js/plugins/vercel-ai): drop misleading @ai-sdk/react peer dependency#5732
Open
ATKasem wants to merge 1 commit into
Open
fix(js/plugins/vercel-ai): drop misleading @ai-sdk/react peer dependency#5732ATKasem wants to merge 1 commit into
ATKasem wants to merge 1 commit into
Conversation
GenkitChatTransport imports only from the framework-agnostic `ai` core package; @ai-sdk/react appears only in a JSDoc example, not as a runtime import. Declaring it as a peer dependency implies React-only support even though the transport works with any Vercel AI SDK UI binding (Vue, Svelte, Angular, or none). Remove it from peerDependencies/peerDependenciesMeta; it stays in devDependencies for the package's own examples and tests. ISSUE: genkit-ai#5616
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes @ai-sdk/react from the peerDependencies and peerDependenciesMeta sections of the js/plugins/vercel-ai/package.json file, while keeping it as a development dependency. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@genkit-ai/vercel-aideclares@ai-sdk/reactas an (optional) peer dependency, which implies React-only support. ButGenkitChatTransport(from@genkit-ai/vercel-ai/client) implements the framework-agnosticChatTransportfrom theaicore package and works with any Vercel AI SDK UI binding — Vue, Svelte, Angular, or none.The package's shipped source imports only from
ai:@ai-sdk/reactappears only inside a JSDoc@examplecomment, never as a runtime import. This removes it frompeerDependenciesandpeerDependenciesMetaso the metadata reflects the actual (binding-agnostic) dependency surface. It stays indevDependencies, which the package's own examples/tests use.Fixes #5616
ISSUE: #5616
Verification
src/imports@ai-sdk/react(only the JSDoc example references it).package.jsonremains valid;@ai-sdk/reactis retained as a devDependency.