Skip to content

fix: use mzi-1x2/mzi-2x2 symbol types instead of mzi - #314

Open
pepijndevos wants to merge 1 commit into
mainfrom
fix/mzi-symbol-types
Open

fix: use mzi-1x2/mzi-2x2 symbol types instead of mzi#314
pepijndevos wants to merge 1 commit into
mainfrom
fix/mzi-symbol-types

Conversation

@pepijndevos

@pepijndevos pepijndevos commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Summary

cspdk emitted schematic("mzi", ...) with symbol "mzi", but Mosaic's device-types only knows mzi-1x2 and mzi-2x2. Mosaic coerced the unknown type to "ckt" (editor.cljc:3070); Livewire wrote the raw invalid "mzi" into the .gsch. This caused MZI cells to render as generic boxes in Mosaic and carry an invalid type in Livewire.

Changes

  • cband/oband (4-port _2X2): mzimzi-2x2
  • si340/si500/sin200/sin300 (3-port _MZI_1X2): mzimzi-1x2

All 6 cspdk _schematic.py files updated. Verified: all variants return the correct symbol name and port count.

Related

Summary by Sourcery

Bug Fixes:

  • Use the correct mzi-1x2 and mzi-2x2 schematic symbol type names so MZI cells render properly and carry valid device types in Mosaic and Livewire.

cspdk emitted schematic("mzi", ...) with symbol "mzi", but Mosaic's
device-types only knows mzi-1x2 and mzi-2x2. Mosaic coerced the unknown
type to "ckt" (editor.cljc:3070); Livewire wrote the raw invalid
"mzi" into the .gsch. This caused MZI cells to render as generic
boxes in Mosaic and carry an invalid type in Livewire.

- cband/oband (4-port _2X2): mzi -> mzi-2x2
- si340/si500/sin200/sin300 (3-port _MZI_1X2): mzi -> mzi-1x2
@sourcery-ai

sourcery-ai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Aligns CSPDK MZI schematic symbol types with Mosaic-supported device types by updating all MZI schematics to use mzi-1x2 or mzi-2x2 instead of the unsupported mzi symbol, ensuring correct port counts and rendering in Mosaic/Livewire.

File-Level Changes

Change Details Files
Update 4‑port MZI schematics to use the mzi-2x2 symbol type instead of the unsupported mzi type.
  • Change the schematic type string from "mzi" to "mzi-2x2" for cband MZI schematics while keeping the _2X2 port configuration.
  • Change the schematic type string from "mzi" to "mzi-2x2" for oband MZI schematics while keeping the _2X2 port configuration.
cspdk/si220/cband/_schematic.py
cspdk/si220/oband/_schematic.py
Update 3‑port MZI schematics to use the mzi-1x2 symbol type instead of the unsupported mzi type.
  • Change the schematic type string from "mzi" to "mzi-1x2" in si340 MZI schematic definitions while keeping the _MZI_1X2 configuration.
  • Change the schematic type string from "mzi" to "mzi-1x2" in si500 MZI schematic definitions while keeping the _MZI_1X2 configuration.
  • Change the schematic type string from "mzi" to "mzi-1x2" in sin200 MZI schematic definitions while keeping the _MZI_1X2 configuration.
  • Change the schematic type string from "mzi" to "mzi-1x2" in sin300 MZI schematic definitions while keeping the _MZI_1X2 configuration.
cspdk/si340/_schematic.py
cspdk/si500/_schematic.py
cspdk/sin200/_schematic.py
cspdk/sin300/_schematic.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@pepijndevos
pepijndevos marked this pull request as ready for review July 23, 2026 13:00
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant