fix: use mzi-1x2/mzi-2x2 symbol types instead of mzi - #314
Open
pepijndevos wants to merge 1 commit into
Open
Conversation
cspdk emitted schematic("mzi", ...) with symbol "mzi", but Mosaic's
device-types only knows mzi-1x2 and mzi-2x2. Mosaic coerced the unknown
type to "ckt" (editor.cljc:3070); Livewire wrote the raw invalid
"mzi" into the .gsch. This caused MZI cells to render as generic
boxes in Mosaic and carry an invalid type in Livewire.
- cband/oband (4-port _2X2): mzi -> mzi-2x2
- si340/si500/sin200/sin300 (3-port _MZI_1X2): mzi -> mzi-1x2
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAligns CSPDK MZI schematic symbol types with Mosaic-supported device types by updating all MZI schematics to use mzi-1x2 or mzi-2x2 instead of the unsupported mzi symbol, ensuring correct port counts and rendering in Mosaic/Livewire. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
pepijndevos
marked this pull request as ready for review
July 23, 2026 13:00
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cspdk emitted
schematic("mzi", ...)with symbol"mzi", but Mosaic'sdevice-typesonly knowsmzi-1x2andmzi-2x2. Mosaic coerced the unknown type to"ckt"(editor.cljc:3070); Livewire wrote the raw invalid"mzi"into the.gsch. This caused MZI cells to render as generic boxes in Mosaic and carry an invalid type in Livewire.Changes
_2X2):mzi→mzi-2x2_MZI_1X2):mzi→mzi-1x2All 6 cspdk
_schematic.pyfiles updated. Verified: all variants return the correct symbol name and port count.Related
?placeholder fix)Summary by Sourcery
Bug Fixes: