Skip to content

v1.60.2.0 fix: restore Conductor AskUserQuestion popups - #2463

Open
danielplant wants to merge 4 commits into
garrytan:mainfrom
danielplant:fix/conductor-ask-user-question-popups
Open

v1.60.2.0 fix: restore Conductor AskUserQuestion popups#2463
danielplant wants to merge 4 commits into
garrytan:mainfrom
danielplant:fix/conductor-ask-user-question-popups

Conversation

@danielplant

Copy link
Copy Markdown

Summary

  • restore clickable Conductor questions by redirecting native AskUserQuestion to mcp__conductor__AskUserQuestion and allowing valid string-option MCP calls through
  • preserve plan-tune auto-decisions first, one-way decision safety, and explicit headless/spawned session behavior
  • retry exactly once only for Conductor's explicit retryable delivery/answer errors; keep success, cancellation, session-unavailable, and the SDK missing-result placeholder from producing duplicate prompts
  • normalize duplicate AUQ hooks when Claude strips source tags, preserve unrelated hooks, back up settings, and retain the prior setup version when migration must retry
  • regenerate host skill guidance and replace the stale Conductor-prose E2E with unavailable-tool fallback coverage

Verification

  • 600 pass, 0 fail across the 8-file affected suite (6,970 assertions)
  • bun run test exits 0 under a fresh isolated HOME on the final tree
  • Claude, Codex, and Factory skill generation dry-runs are fresh
  • focused routing, fallback, settings, and migration suite: 77 pass, 0 fail
  • bash -n and git diff --check pass
  • independent whole-branch reviews found and drove fixes for headless Conductor routing, failed-migration version advancement, and mid-option (recommended) parsing

Rollout

No Conductor application or LegalMind code changes are included. After merge, upgrade the installed gstack copy, run setup so hook normalization executes, then start a fresh Conductor Claude session and verify popup success, Other, multi-select, multiple questions, auto-decision bypass, and one-way decisions. Live popup acceptance remains a post-merge rollout gate because the current Codex session does not expose mcp__conductor__AskUserQuestion.

@trunk-io

trunk-io Bot commented Aug 6, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant