fix: harden Windows runtime path resolution - #2439
Open
punksterlabs wants to merge 1 commit into
Open
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
browse.exestart from the shipped adjacentserver-node.mjswithout requiringbrowse/src/server.ts$GSTACK_ROOT-backed hosts and~-backed hostsWhy
Codex installs use a minimal runtime root. On Windows that root intentionally ships the compiled browser CLI and
server-node.mjs, but not the TypeScript source tree. The CLI resolvedserver.tseagerly before selecting the Windows Node bundle, so a valid minimal install could fail with a missing-source/binary-setup error.Generated setup blocks also prefixed
$HOMEonto env-var-backed runtime roots, and nestedbashlookups could resolve to Windows' WSL launcher even when the outer build was already running in Git Bash.Validation
bun run buildfrom Git for Windows Bashbun run scripts/gen-skill-docs.ts --host all --dry-runbun test browse/test/config.test.ts browse/test/build.test.ts test/resolver-runtime-paths.test.ts test/gen-skill-docs.test.ts— 449 passed, 0 failedgit diff --checkThe broader Windows suite still contains unrelated Unix-environment assumptions in migration/Codex probe tests; upstream Linux CI remains the authoritative full-suite check.