Fix wayland socket wait - #73
Merged
Merged
Conversation
Apps configured with start_virtual_compositor = false have no Wayland socket of their own, so Wolf reports an empty socket name to its readiness check. The check then stats XDG_RUNTIME_DIR itself, finds a directory, and aborts the session: ERROR | Wayland endpoint /tmp/sockets/ exists but is not a socket ERROR | [STREAM_SESSION] Wayland socket was not ready, aborting runner startup Wolf's built-in "Test ball" is the only app in the default config that hits this, which is unfortunate because it is the app people try first. Apps with their own compositor (Steam, Firefox, the Wolf UI) are fine. Set WOLF_SKIP_WAYLAND_SOCKET_WAIT=TRUE in both generated Compose files, and patch it into an already-generated one from update.sh, since Update Images does not regenerate the file. diagnose.sh reports whether the running container actually has it. Upstream: games-on-whales/wolf#462 Refs: games-on-whales/wolf#483
The wolf-den comment contains `socat ... UNIX-CONNECT:${WOLF_SOCKET_PATH}`
in backticks, inside an unquoted heredoc. Bash treats that as command
substitution, so every deploy printed
deploy.sh: line N: WOLF_SOCKET_PATH: unbound variable
to the install log (set -u kills the expansion before socat runs, so
nothing is actually executed) and wrote the comment into the generated
docker-compose.yml with the backticked span replaced by nothing:
# this straight to to build a
Escape the backticks and the expansion so the comment survives verbatim.
Cosmetic, but the stray error line is noise in exactly the logs people
paste into bug reports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.