chore: bump all GitHub/Docker actions to latest major versions#285
chore: bump all GitHub/Docker actions to latest major versions#285frostebite wants to merge 2 commits into
Conversation
Bump all action dependencies to their latest major versions, ahead of the June 2 2026 deadline when GitHub will force Node.js 24 for all actions. All upgrades verified safe with no breaking changes affecting current usage. - actions/checkout: v5 → v6 - actions/cache: v4 → v5 - actions/upload-artifact: v4 → v5 - actions/download-artifact: v4 → v6 - docker/build-push-action: v5 → v7 - docker/login-action: v3 → v4 - docker/setup-buildx-action: v3 → v4 - docker/setup-qemu-action: v3 → v4 Also adds npm ecosystem to dependabot.yml so the report-to-backend action's dependencies are kept up to date automatically. Supersedes #247, #264, #265, #270, #274. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
📝 WalkthroughWalkthroughThis PR performs a systematic upgrade of GitHub Actions versions across all CI/CD workflows, migrates Windows Hub installation from Chocolatey to PowerShell, adds Docker service startup handling for Windows builds, and configures Dependabot for npm dependency management in the report-to-backend actions directory. ChangesCI/CD Infrastructure Upgrade
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
webbertakken
left a comment
webbertakken
left a comment
There was a problem hiding this comment.
This isn't always as simple as a bump in the action.
Especially for Cache it's been known to break in the past.
That said, if your agent checked all the upgrade notes we should be good
frostebite
left a comment
frostebite
left a comment
There was a problem hiding this comment.
Yes — each upgrade was cross-referenced against the actual release notes, changelogs, and action.yml diffs. Here's what we found:
actions/cache v4 → v5 (your main concern): As far as we can tell, the v4 and v5 action.yml inputs are identical — path, key, restore-keys, upload-chunk-size, enableCrossOsArchive, fail-on-cache-miss, lookup-only all appear unchanged. The only difference we see is the Node runtime bump (20 → 24). Our usage is the simplest possible pattern (path + key + restore-keys for buildx layer caching in the base/hub workflows) — which should be fully supported.
docker/build-push-action v5 → v7: We didn't find any removed inputs or changed defaults. The main addition is automatic build summaries in job output (cosmetic, added in v6). Two deprecated env vars were removed in v7 (DOCKER_BUILD_NO_SUMMARY, DOCKER_BUILD_EXPORT_RETENTION_DAYS) — neither appears to be used here.
docker/setup-buildx-action v3 → v4: Three deprecated inputs were removed (config, config-inline, install) — none of which seem to be used in our workflows. Our usages are either bare or driver: docker.
docker/login-action v3 → v4, docker/setup-qemu-action v3 → v4: Node runtime bump only as far as we can tell, no input/output changes found.
actions/checkout v5 → v6: Credential storage moved to $RUNNER_TEMP. Should be transparent for our usage (bare or fetch-depth: 0).
actions/upload-artifact v4 → v5, actions/download-artifact v4 → v6: Primarily Node runtime bumps. download-artifact v5 had a breaking change for downloads by artifact ID — we download by name only, so it shouldn't apply.
All workflows use GitHub-hosted runners (ubuntu-latest / windows-2022), which should already meet the runner v2.329.0+ requirement for all of these.
That said, if you've seen cache-specific issues with bumps in the past, we're happy to split that one out into a separate PR so it can be tested in isolation.
|
About the failures in CI, looks like that is a stale cache issue. |
The choco unity-hub package downloads from UnityHubSetup.exe which now returns 404; switch to direct CDN download of UnityHubSetup-x64.exe. Add escape directive so backtick line-continuation works in the Dockerfile. Add Start Docker step so the daemon is running before docker build commands. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/new-windows-hub-image-requested.yml (1)
54-57:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winCritical: Missing
$prefix in GitHub expression syntax.Lines 54-57 are missing the
$prefix before{{in the GitHub Actions expression syntax. This will prevent variable interpolation when the workflow is triggered viaworkflow_dispatch.🐛 Proposed fix
if ("${{ github.event.inputs.jobId }}") { # Workflow Dispatch - echo "jobId={{ github.event.inputs.jobId }}" >> $Env:GITHUB_OUTPUT - echo "repoVersionFull={{ github.event.inputs.repoVersionFull }}" >> $Env:GITHUB_OUTPUT - echo "repoVersionMinor={{ github.event.inputs.repoVersionMinor }}" >> $Env:GITHUB_OUTPUT - echo "repoVersionMajor={{ github.event.inputs.repoVersionMajor }}" >> $Env:GITHUB_OUTPUT + echo "jobId=${{ github.event.inputs.jobId }}" >> $Env:GITHUB_OUTPUT + echo "repoVersionFull=${{ github.event.inputs.repoVersionFull }}" >> $Env:GITHUB_OUTPUT + echo "repoVersionMinor=${{ github.event.inputs.repoVersionMinor }}" >> $Env:GITHUB_OUTPUT + echo "repoVersionMajor=${{ github.event.inputs.repoVersionMajor }}" >> $Env:GITHUB_OUTPUT } else🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/new-windows-hub-image-requested.yml around lines 54 - 57, Update the GitHub Actions expression syntax used in the echo commands so the input variables interpolate correctly: replace the bare {{ github.event.inputs.jobId }}, {{ github.event.inputs.repoVersionFull }}, {{ github.event.inputs.repoVersionMinor }}, and {{ github.event.inputs.repoVersionMajor }} with the proper expression form ${{ github.event.inputs.jobId }}, ${{ github.event.inputs.repoVersionFull }}, ${{ github.event.inputs.repoVersionMinor }}, and ${{ github.event.inputs.repoVersionMajor }} in the PowerShell echo lines that write to $Env:GITHUB_OUTPUT (the echo statements shown in the diff).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In @.github/workflows/new-windows-hub-image-requested.yml:
- Around line 54-57: Update the GitHub Actions expression syntax used in the
echo commands so the input variables interpolate correctly: replace the bare {{
github.event.inputs.jobId }}, {{ github.event.inputs.repoVersionFull }}, {{
github.event.inputs.repoVersionMinor }}, and {{
github.event.inputs.repoVersionMajor }} with the proper expression form ${{
github.event.inputs.jobId }}, ${{ github.event.inputs.repoVersionFull }}, ${{
github.event.inputs.repoVersionMinor }}, and ${{
github.event.inputs.repoVersionMajor }} in the PowerShell echo lines that write
to $Env:GITHUB_OUTPUT (the echo statements shown in the diff).
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 7a305f04-7154-4cbc-bfe9-ab26c4db81b6
📒 Files selected for processing (14)
.github/dependabot.yml.github/workflows/main.yml.github/workflows/new-ubuntu-base-image-requested.yml.github/workflows/new-ubuntu-hub-image-requested.yml.github/workflows/new-ubuntu-legacy-editor-image-requested.yml.github/workflows/new-ubuntu-post-2019-2-editor-image-requested.yml.github/workflows/new-windows-base-image-requested.yml.github/workflows/new-windows-hub-image-requested.yml.github/workflows/new-windows-legacy-editor-image-requested.yml.github/workflows/new-windows-post-2019-2-editor-image-requested.yml.github/workflows/retry-ubuntu-editor-image-requested.yml.github/workflows/retry-windows-editor-image-requested.yml.github/workflows/test.ymlimages/windows/hub/Dockerfile
2 participants
Summary
Bumps all action dependencies to their latest major versions, ahead of the June 2 2026 deadline when GitHub will force Node.js 24 for all actions.
All upgrades have been verified safe — no breaking changes affect current usage patterns in this repository.
actions/checkoutactions/cacheactions/upload-artifactactions/download-artifactdocker/build-push-actiondocker/login-actiondocker/setup-buildx-actiondocker/setup-qemu-actionAlso adds
npmecosystem todependabot.ymlso thereport-to-backendaction'spackage.jsondependencies are tracked automatically.Supersedes #247, #264, #265, #270, #274 (stale dependabot PRs that were already behind latest).
Files changed
All 13 workflow files +
.github/dependabot.ymlBreaking change review
$RUNNER_TEMP(transparent)Test plan
test.ymlworkflow passes on a PR build🤖 Generated with Claude Code
Summary by CodeRabbit
Chores
Bug Fixes