Skip to content

feat(particle): support custom particle shaders with custom data #3004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hhhhkrx wants to merge 2 commits into
base: dev/2.0
Choose a base branch
from

test(particle): loosen customShader e2e diff threshold for CI

ada8712
Select commit
Loading
Failed to load commit list.
Open

feat(particle): support custom particle shaders with custom data #3004

test(particle): loosen customShader e2e diff threshold for CI
ada8712
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed May 13, 2026 in 0s

78.01% (-0.13%) compared to 25ba6eb

View this Pull Request on Codecov

78.01% (-0.13%) compared to 25ba6eb

Details

Codecov Report

❌ Patch coverage is 51.34228% with 145 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.01%. Comparing base (25ba6eb) to head (ada8712).
⚠️ Report is 1 commits behind head on dev/2.0.

Files with missing lines Patch % Lines
...ages/core/src/particle/modules/CustomDataModule.ts 59.64% 92 Missing ⚠️
e2e/case/particleRenderer-customShader.ts 0.00% 45 Missing and 1 partial ⚠️
e2e/config.ts 0.00% 6 Missing ⚠️
packages/core/src/particle/ParticleMaterial.ts 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           dev/2.0    #3004      +/-   ##
===========================================
- Coverage    78.14%   78.01%   -0.13%     
===========================================
  Files          900      902       +2     
  Lines        99255    99547     +292     
  Branches     10213    10203      -10     
===========================================
+ Hits         77563    77666     +103     
- Misses       21521    21709     +188     
- Partials       171      172       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov