-
-
Notifications
You must be signed in to change notification settings - Fork 399
fix(animation, loader): 从 #2983 抽离动画与 GLTF 加载器修复 #2999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
luzhuang
wants to merge
84
commits into
galacean:dev/2.0
Choose a base branch
from
luzhuang:fix/animation-loader
base: dev/2.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
84 commits
Select commit
Hold shift + click to select a range
b5a0ca6
fix(animation): normalize single-root clip binding paths
luzhuang df4dab8
fix(animation): add per-instance speed to AnimatorStatePlayData
luzhuang 28f5e21
fix(loader): normalize gltf wrapper and skin roots
luzhuang 234164e
refactor(animation): per-state PlayData handle with override-aware speed
luzhuang 1cc59e8
refactor(animation): clipless-state safety + move PlayData out of int…
luzhuang 296e5b9
test(animation): per-state PlayData handle and per-instance speed
luzhuang fa4ce1b
test(animation): refine per-instance speed regression tests
luzhuang 8825d6b
fix(loader): _findSceneRootBone walk-up termination
luzhuang f58640a
fix(entity): findByPath prefers same-name child over self-prefix
luzhuang f2cbd10
fix(e2e): update findAnimatorState callers for new return type
luzhuang f297fe8
fix(animation): forbid crossFade to active state and reset orientatio…
luzhuang cb5cfd5
fix(entity): tighten findByPath self-prefix fallback
luzhuang d53b722
fix(animation): prettier formatting for crossFade alias guard
luzhuang bcf9611
docs(animation): update findAnimatorState examples for new API
luzhuang 722cc2b
fix(e2e): null-guard findAnimatorState callers
luzhuang a2d3c2e
fix(loader): _findSceneRootBone only returns wrapper when joints span…
luzhuang 7fab893
fix(animation): _preparePlay clears stale crossFade slot
luzhuang 33a676b
fix(animation): crossFade early-return on missing state
luzhuang fd1da52
docs(animation): mark playState as @internal
luzhuang 862ddda
fix(entity): findByPath fallback no longer crashes on null parent
luzhuang 7462264
fix(animation): _getAnimatorStateInfo bounds-check layerIndex
luzhuang 4edcd90
fix(animation): guard remaining-time math against zero playSpeed
luzhuang affa3ee
docs(loader): document Scene-before-Skin parse-order dependency
luzhuang b1e67f2
style(e2e): camelCase local transition variables in animator-stateMac…
luzhuang 4ecfa0f
test(animation): add missing @ts-ignore on _animatorLayersData[99] ac…
luzhuang aa5132c
refactor(animation): align statePlayDataMap with Record + Object.crea…
luzhuang 34efeaa
docs(animation): clarify pause vs resume in per-instance speed example
luzhuang 55a96bf
docs(animation): mark self-crossFade no-op as intentional policy
luzhuang 86a0bf1
perf(loader): _findSceneRootBone avoids Set allocations
luzhuang b6205bd
refactor(entity): _findChildByPathDown helper for self-prefix fallback
luzhuang e230a51
test(animation): state-machine self-transition is no-op
luzhuang 36e2f40
test(animation): cover _updatePlayingState playSpeed===0 guard
luzhuang 4ed7145
refactor(animation): underscore-prefix internal AnimatorStatePlayData…
luzhuang 500657e
refactor(entity): findByPath polish from review feedback
luzhuang e396243
docs(animation): tighten self-cross-fade no-op comment per review
luzhuang cc481e1
fix(entity): _findChildByPathDown retries same-name siblings on deep …
luzhuang 85b82d8
fix(animation): rebuild PlayData when AnimatorState identity changes
luzhuang 6893ac2
fix(animation): findAnimatorState honors controller update flag
luzhuang 8c5c9a3
fix(animation): rebuild AnimatorStateData when state identity changes
luzhuang 4caa2bf
fix(animation): detach stateData listeners on _reset to prevent accum…
luzhuang ce40c43
fix(animation): _onDestroy reuses _reset to detach stateData listeners
luzhuang 15d88f5
revert(entity): remove self-prefix fallback from findByPath
luzhuang 9d296b0
refactor(animation): collapse getOrCreatePlayData guard with optional…
luzhuang 5859036
refactor(animation): drop clearSpeedOverride, treat speed write as final
luzhuang eec99ad
refactor(animation): tighten AnimatorStateData lifecycle invariants
luzhuang aed9e10
docs(animation): document getCurrentAnimatorState nullable return
luzhuang 88ff930
docs(loader): warn against Skin-await-Scene cycle next to Scene-befor…
luzhuang 6230dca
refactor(loader): drop _findSceneRootBone, resolve skin rootBone via …
luzhuang 31e711e
docs(loader): update Scene-before-Skin comment after LCA unification
luzhuang 82026ee
refactor(animation): rename _speedOverride to _speed after dropping o…
luzhuang 35a3147
refactor(animation): extract _resetIfControllerUpdated helper
luzhuang 479a8be
docs(animation): tighten AnimatorStatePlayData class doc and explain …
luzhuang 4457f62
docs(loader): explain why _sceneRoots[i] is written synchronously
luzhuang 31344e5
docs(loader): tighten skin rootBone resolution comments
GuoLei1990 7882a1f
revert(loader): drop orphan _sceneRoots[i] synchronous write
GuoLei1990 b109a42
docs(loader): tighten skin rootBone resolution comments
GuoLei1990 ddcb9ee
refactor(loader): revert _findSkeletonRootBone rename
GuoLei1990 efa4795
docs(entity): fix stale @returns text on getChild and findByName
GuoLei1990 fe78f5e
refactor(animation): split AnimatorState into asset (Def) and per-ins…
GuoLei1990 e94f036
refactor(animation): adapt tests, e2e and docs to AnimatorState view API
GuoLei1990 47fc4ba
refactor(animation): demote AnimatorState.def to @internal
GuoLei1990 4c84eba
Merge branch 'dev/2.0' into redesign-animator-state-view
GuoLei1990 a4a6974
refactor(animation): rename per-instance view to AnimatorStateInstance
GuoLei1990 f1709c4
refactor(animation): trim verbose comments on instance/runtime types …
GuoLei1990 12d3ee4
refactor(animation): rename Def-suffixed locals in e2e cases to State
GuoLei1990 6c26f4b
refactor(animation): drop implementation details from public JSDoc
GuoLei1990 92529bb
feat(animation): make wrapMode per-instance overrideable on AnimatorS…
GuoLei1990 0e30020
refactor(animation): restore AnimatorStatePlayData naming
GuoLei1990 50d9ff9
refactor(animation): clean up Instance/PlayData ownership and naming
GuoLei1990 a0c21a3
refactor(animation): drop redundant layerIndex<0 check after !state g…
GuoLei1990 86b8398
fix(animation): dispatch controller update flag on stateMachine state…
GuoLei1990 8292d1a
refactor(animation): lazy version + WeakMap for state-keyed caches
GuoLei1990 4b4fe7f
refactor(animation): drop unused event handler pool, rename to _ensur…
GuoLei1990 efc428f
style(animation): drop redundant self-rename in destructures
GuoLei1990 4e7d18d
refactor(animation): collapse cross-fade slot reset into AnimatorLaye…
GuoLei1990 04cb804
docs(animation): expand AnimatorStateInstance JSDoc
GuoLei1990 ca72f7f
style(animation): expand single-line getter JSDoc to multi-line
GuoLei1990 faf95c6
fix(animation): clear defaultState on removeState to drop dangling ref
GuoLei1990 fb529ba
style(updateflagmanager): drop redundant prose comment on _version
GuoLei1990 e6b861f
style(animatorstatedata): drop redundant prose comment on eventsBuilt…
GuoLei1990 04009e0
refactor(animation): revert AnimatorStatePlayData.resetForPlay to reset
GuoLei1990 8e1c131
style(animatorlayerdata): drop redundant method JSDoc
GuoLei1990 f167d01
fix(animation, loader): test assertion + getCurrentAnimatorState rese…
GuoLei1990 7b52bfc
fix(animation): ensure event handlers in update path; fix stale test …
GuoLei1990 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guard animator and layer before walk-state lookup.
animatorandlayers[0]can fail before your explicit"walk"error path, giving a less actionable crash. Add explicit checks first.Suggested patch
🤖 Prompt for AI Agents