Skip to content

Refactor sprite and text renderable components #2929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cptbtptpbcptdtptp wants to merge 10 commits into
base: dev/2.0
Choose a base branch
from

refactor(2d): move common renderable properties to base classes

cc36ac3
Select commit
Loading
Failed to load commit list.
Draft

Refactor sprite and text renderable components #2929

refactor(2d): move common renderable properties to base classes
cc36ac3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 14, 2026 in 1s

77.39% (+0.03%) compared to 4676132

View this Pull Request on Codecov

77.39% (+0.03%) compared to 4676132

Details

Codecov Report

❌ Patch coverage is 65.49020% with 1056 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.39%. Comparing base (4676132) to head (cc36ac3).
⚠️ Report is 41 commits behind head on dev/2.0.

Files with missing lines Patch % Lines
packages/ui/src/component/UIRenderer.ts 48.44% 149 Missing ⚠️
examples/src/ui-03-rectmask.ts 0.00% 133 Missing and 1 partial ⚠️
packages/core/src/2d/sprite/SpriteMaskUtils.ts 16.91% 113 Missing ⚠️
examples/src/ui-02-mask.ts 0.00% 100 Missing and 1 partial ⚠️
packages/core/src/2d/text/TextRenderable.ts 86.13% 99 Missing ⚠️
examples/src/2d-01-sprite-mask.ts 0.00% 95 Missing and 1 partial ⚠️
packages/ui/src/component/advanced/RectMask2D.ts 48.40% 81 Missing ⚠️
examples/src/ui-01-basic.ts 0.00% 66 Missing and 1 partial ⚠️
packages/core/src/RenderPipeline/MaskManager.ts 33.33% 42 Missing ⚠️
packages/core/src/RenderPipeline/BatchUtils.ts 0.00% 34 Missing ⚠️
... and 12 more
Additional details and impacted files 
@@             Coverage Diff             @@
##           dev/2.0    #2929      +/-   ##
===========================================
+ Coverage    77.36%   77.39%   +0.03%     
===========================================
  Files          898      907       +9     
  Lines        98290    99106     +816     
  Branches      9672     9822     +150     
===========================================
+ Hits         76038    76700     +662     
- Misses       22087    22235     +148     
- Partials       165      171       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov