[FIX] Keep selection when switching between graph and map#368
Open
micw wants to merge 2 commits into
Open
Conversation
Contributor
|
Preview deployed: https://freifunk.github.io/meshviewer/pr-preview/pr-368/ Updated for commit 10b34aa. |
Signed-off-by: Michael Wyraz <michael@wyraz.de>
Signed-off-by: Michael Wyraz <michael@wyraz.de>
micw
force-pushed
the
feature/map-graph-keep-selection
branch
from
7ef9e09 to
10b34aa
Compare
Contributor
Author
|
I love the preview CI feature! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When selecting a node ans switching between graph/map view, the node selection was lost. This fixes it.
Also
router.fullUrlwas fixed to not add an extra hash to the path. The same issue was already fixed in an older commit for switching the language but not forrouter.fullUrl. And I added a test for this ;-)Motivation and Context
It's was a bug. Now it's fixed.
How Has This Been Tested?
Fixefox, Unit Test
Screenshots/links:
Checklist: