Skip to content

fix(ci): align workflow Python version with requires-python - #5032

Open
MGPOCKY wants to merge 1 commit into
frappe:developfrom
MGPOCKY:fix/ci-python-version-mismatch
Open

fix(ci): align workflow Python version with requires-python#5032
MGPOCKY wants to merge 1 commit into
frappe:developfrom
MGPOCKY:fix/ci-python-version-mismatch

Conversation

@MGPOCKY

@MGPOCKY MGPOCKY commented Jul 31, 2026

Copy link
Copy Markdown

Why

Package metadata declares requires-python / .python-version as >=3.10, but CI workflows still pin python-version to a mismatched value.

That can make CI run on a runtime the project no longer supports (or skip the version the package actually targets).

What changed

Update the affected workflow python-version pins so they satisfy >=3.10 (using 3.10 where a concrete pin is needed).

  • .github/workflows/docs_checker.yml
    • python-version: 3.8python-version: 3.10

Test plan

  • Package requires-python / .python-version is still >=3.10
  • Updated workflows now use versions consistent with that constraint
  • Relevant CI jobs on this branch look healthy

Found while auditing CI/package version consistency across popular repos.

@MGPOCKY
MGPOCKY marked this pull request as ready for review July 31, 2026 08:30
@MGPOCKY
MGPOCKY requested a review from asmitahase as a code owner July 31, 2026 08:30
@greptile-apps

greptile-apps Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 4/5

This needs the Python version quoted before merging so the docs checker reliably installs Python 3.10.

The unquoted trailing-zero version can reach setup-python as 3.1 and stop the workflow before validation executes.

Files Needing Attention: .github/workflows/docs_checker.yml

Reviews (1): Last reviewed commit: "fix(ci): align workflow Python version w..." | Re-trigger Greptile

uses: actions/setup-python@v6
with:
python-version: 3.8
python-version: 3.10

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Unquoted version resolves as 3.1

When this workflow starts, YAML coerces unquoted 3.10 to 3.1, causing environment setup to request the wrong Python version and fail before documentation validation runs.

Suggested change
python-version: 3.10
python-version: '3.10'

@github-actions

Copy link
Copy Markdown

This pull request is being marked as inactive because of no recent activity.
If your PR hasn't been reviewed, it's likely because it doesn't fullfill the contribution guidelines. Please read them carefully and fix the pull request. When you are sure all items are checked, please ping relevant codeowner in the comment. Be nice, they have a lot on their plate too.

It will be closed in 3 days if no further activity occurs.
Thank you for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant