fix(hr): exclude cancelled Expense Claims in Vehicle Log make_expense_claim - #5022
Open
itsdivvy wants to merge 4 commits into
Open
fix(hr): exclude cancelled Expense Claims in Vehicle Log make_expense_claim#5022itsdivvy wants to merge 4 commits into
itsdivvy wants to merge 4 commits into
Conversation
itsdivvy
force-pushed
the
fix/divvy-hrms-bug-006
branch
from
July 29, 2026 10:18
8d813b3 to
e0c33fc
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
Confidence Score: 4/5The implementation appears safe to merge, but restore the displaced Vehicle Log cancellation assertions. The functional fix is sound, while the test edit silently removes coverage from an existing cancellation workflow. Files Needing Attention: hrms/hr/doctype/vehicle_log/test_vehicle_log.py Reviews (5): Last reviewed commit: "fix(test): cancel and delete vehicle log..." | Re-trigger Greptile |
itsdivvy
force-pushed
the
fix/divvy-hrms-bug-006
branch
from
July 29, 2026 10:20
e0c33fc to
e950963
Compare
…m_after_cancellation
…move duplicate test
Contributor
|
Want your agent to iterate on Greptile's feedback? Try greploops. |
deepeshgarg007
approved these changes
Aug 5, 2026
deepeshgarg007
enabled auto-merge
August 5, 2026 10:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes