feat(optimizer): bump Rust toolchain to 1.93.1 - #2
Merged
Merged
Conversation
psibi
reviewed
Feb 19, 2026
| RUN cd binaryen-version_*/ \ | ||
| && git clone --depth 1 https://github.com/google/googletest.git ./third_party/googletest \ | ||
| - && cmake . -G Ninja -DCMAKE_CXX_FLAGS="-static" -DCMAKE_C_FLAGS="-static" -DCMAKE_BUILD_TYPE=Release -DBUILD_STATIC_LIB=ON \ | ||
| + && cmake . -G Ninja -DCMAKE_CXX_FLAGS="-static -Wno-error=maybe-uninitialized" -DCMAKE_C_FLAGS="-static" -DCMAKE_BUILD_TYPE=Release -DBUILD_STATIC_LIB=ON \ |
Member
There was a problem hiding this comment.
What is this for:
-Wno-error=maybe-uninitialized
Contributor
Author
There was a problem hiding this comment.
Build was failing with this error:
34.85 ninja: job failed: /usr/bin/c++ -I/binaryen-version_116/src -I/binaryen-version_116/third_party/llvm-project/include -I/binaryen-version_116 -static -DBUILD_LLVM_DWARF -Wall -Werro
r -Wextra -Wno-unused-parameter -fno-omit-frame-pointer -fno-rtti -Wno-implicit-int-float-conversion -Wno-unknown-warning-option -Wswitch -Wimplicit-fallthrough -Wnon-virtual-dtor -fPIC -
fdiagnostics-color=always -O3 -DNDEBUG -UNDEBUG -std=c++17 -MD -MT src/passes/CMakeFiles/passes.dir/Strip.cpp.o -MF src/passes/CMakeFiles/passes.dir/Strip.cpp.o.d -o src/passes/CMakeFiles
/passes.dir/Strip.cpp.o -c /binaryen-version_116/src/passes/Strip.cpp
34.85 In file included from /usr/include/c++/15.2.0/functional:61,
34.85 from /binaryen-version_116/src/passes/Strip.cpp:22:
34.85 In copy constructor 'std::function<_Res(_ArgTypes ...)>::function(const std::function<_Res(_ArgTypes ...)>&) [with _Res = bool; _ArgTypes = {wasm::CustomSection&}]',
34.85 inlined from 'wasm::Strip::Strip(Decider)' at /binaryen-version_116/src/passes/Strip.cpp:37:28,
34.85 inlined from 'wasm::Pass* wasm::createStripDebugPass()' at /binaryen-version_116/src/passes/Strip.cpp:62:4:
34.85 /usr/include/c++/15.2.0/bits/std_function.h:393:17: error: '<anonymous>' may be used uninitialized [-Werror=maybe-uninitialized]
34.85 393 | __x._M_manager(_M_functor, __x._M_functor, __clone_functor);
34.85 | ~~~~^~~~~~~~~~
34.85 /usr/include/c++/15.2.0/bits/std_function.h: In function 'wasm::Pass* wasm::createStripDebugPass()':
34.85 /usr/include/c++/15.2.0/bits/std_function.h:269:7: note: by argument 2 of type 'const std::_Any_data&' to 'static bool std::_Function_handler<_Res(_ArgTypes ...), _Functor>::_M_mana
ger(std::_Any_data&, const std::_Any_data&, std::_Manager_operation) [with _Res = bool; _Functor = wasm::createStripDebugPass()::<lambda(const wasm::CustomSection&)>; _ArgTypes = {wasm::C
ustomSection&}]' declared here
34.85 269 | _M_manager(_Any_data& __dest, const _Any_data& __source,
34.85 | ^~~~~~~~~~
34.85 /binaryen-version_116/src/passes/Strip.cpp:58:20: note: '<anonymous>' declared here
34.85 58 | return new Strip([&](const CustomSection& curr) {
34.85 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
34.85 59 | return curr.name == BinaryConsts::CustomSections::Name ||
34.85 | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
34.85 60 | curr.name == BinaryConsts::CustomSections::SourceMapUrl ||
34.85 | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
34.85 61 | curr.name.find(".debug") == 0 || curr.name.find("reloc..debug") == 0;
34.85 | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
34.85 62 | });
34.85 | ~
Contributor
Author
There was a problem hiding this comment.
It suppresses a warning that is treated like an error by compiler flags. I did not want to go deeper into fixing the code I'm not familiar with. I'm also not feeling great about ignoring a compiler warning, but since its not our product, as long as it works - should be ok, I think?
Member
There was a problem hiding this comment.
Not sure, I believe we will know once we run the tests against kolme. :-)
psibi
approved these changes
Feb 19, 2026
psibi
left a comment
psibi
left a comment
Member
There was a problem hiding this comment.
Nice work with the patch file! LGTM, merge it once the CI turns green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.