feat(config): allow byte-based storage watermark#254
Merged
Conversation
detsch
force-pushed
the
detsch-bytes-watermark-v2
branch
from
f9dc05b to
bd16dd3
Compare
mike-sul
reviewed
Jun 19, 2026
detsch
force-pushed
the
detsch-bytes-watermark-v2
branch
3 times, most recently
from
2a60a48 to
365d132
Compare
pacman.storage_watermark only accepted a percentage of total storage, a clumsy way to reserve a fixed amount of free space on large data partitions. Rather than overloading that key, add a separate pacman.reserved_storage option that takes an absolute size (e.g. "2GiB"), parsed with go-units, so the two meanings stay unambiguous. reserved_storage takes precedence: when both keys are set the percentage watermark is ignored and a warning is logged. The value is forwarded to composeapp's GetUsageInfo via the watermark-in-bytes flag, which is unchanged. Signed-off-by: Andre Detsch <andre.detsch@foundries.io> Assisted-by: Claude Code:claude-opus-4-8
detsch
force-pushed
the
detsch-bytes-watermark-v2
branch
from
365d132 to
a924b39
Compare
Collaborator
|
I would probably extend the doc with info about configuring storage usage, I think a new section (Configure Storage Usage) just after this https://github.com/foundriesio/fioup/blob/main/docs/update-device.md#configure-image-pruning-mode would be OK. |
mike-sul
approved these changes
Jun 22, 2026
mike-sul
left a comment
mike-sul
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, probably worth adding a new section into the doc about the storage usage configuration.
fioup gates updates on available storage via pacman.storage_watermark and pacman.reserved_storage, but neither option was described in the user-facing update guide. Document both, the binary/decimal byte suffixes accepted by reserved_storage, and the precedence rule when both keys are set. Signed-off-by: Andre Detsch <andre.detsch@foundries.io> Assisted-by: Claude Code:claude-opus-4-8
mike-sul
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pacman.storage_watermark only accepted a percentage of total storage, which is a clumsy way to reserve a fixed amount of free space on large data partitions. A bare integer still means a percentage; a value with a size suffix (e.g. "2GiB") now reserves that absolute amount, parsed with go-units and forwarded to composeapp's GetUsageInfo via the new watermark-in-bytes flag.
Assisted-by: Claude Code:claude-opus-4-8
Depends on foundriesio/composeapp#141