Chores/setup agentic coding#139
Merged
Merged
Conversation
mike-sul
commented
Jun 9, 2026
mike-sul
commented
Collaborator
- Setup basic context and rules for AI agents.
- Fix tiny issue in Makefile found by the agent.
doanac
reviewed
Jun 9, 2026
| @@ -57,7 +57,7 @@ format: | |||
| @$(GO) fmt ./... | |||
Member
There was a problem hiding this comment.
on the commit message. It's not strictly required, but I'm seeing people include the model used to assist like "Opus 4.6". The kernel suggests this format:
https://docs.kernel.org/process/coding-assistants.html#attribution
I've also seen Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
doanac
reviewed
Jun 9, 2026
doanac
left a comment
doanac
left a comment
Member
There was a problem hiding this comment.
I like it. Just one question about attribution format
The test-unit target listed ./pkg/docker/..., but that package no longer exists — its tests now live under pkg/compose. go test resolves patterns before running, so the missing path made the entire target exit non-zero and skipped every real test. Removing the dead path (and normalizing ./internal... to ./internal/...) restores a working, verifiable unit suite. Signed-off-by: Mike Sul <mike.sul@foundries.io> Assisted-by: Claude Code:claude-opus-4-8
AI coding agents contributing to this repo need explicit, enforceable guardrails. Without them, agents drift from project conventions, run toolchains against an unpredictable host, and leak per-tool config into version control. This commit establishes that foundation: - AGENTS.md codifies the operating rules (containerized validation, Go version pinning, architectural bounds, commit attribution) so agent contributions stay safe, reproducible, and reviewable. - CLAUDE.md redirects Claude Code to those shared rules, avoiding a second, divergent copy of the guidance per tool. - .gitignore is extended to exclude per-agent caches, logs, and local overrides (Claude, Cursor, Aider, Codex, etc.) so ephemeral tooling state never lands in history. Routing every build, lint, and test target through the project container guarantees Go 1.22 toolchain alignment and keeps host machine pollution from masking real failures. Signed-off-by: Mike Sul <mike.sul@foundries.io> Assisted-by: Claude Code:claude-opus-4-8
mike-sul
force-pushed
the
chores/setup-agentic-coding
branch
from
da5130b to
9de76dd
Compare
doanac
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.