Skip to content
This repository was archived by the owner on May 21, 2026. It is now read-only.

fix: #2435 Login and signup button enabe/disable - #2468

Open
gagankumre wants to merge 4 commits into
fossasia:developmentfrom
gagankumre:gd
Open

fix: #2435 Login and signup button enabe/disable#2468
gagankumre wants to merge 4 commits into
fossasia:developmentfrom
gagankumre:gd

Conversation

@gagankumre

@gagankumre gagankumre commented Jan 27, 2020

Copy link
Copy Markdown

fix: #2435 login and signup button get enable and disable according to the input of credentials

Changes: Until the email id and password is filled up the Login/Sign Up button will remain disabled and fade in colour

Screenshots for the change:

login page-
WhatsApp Image 2020-01-27 at 3 05 20 PM

WhatsApp Image 2020-01-27 at 3 05 20 PM (4)

Signup page-

WhatsApp Image 2020-01-27 at 3 05 20 PM (2)

WhatsApp Image 2020-01-27 at 3 05 20 PM (1)

@ci-reporter

ci-reporter Bot commented Jan 27, 2020

Copy link
Copy Markdown

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of d755f2e. Here's the output:

spotless check
> Task :spotlessCheck UP-TO-DATE

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!


Failed build for d755f2e
spotless check
> Task :spotlessCheck UP-TO-DATE
Failed build for d72bec6
spotless check
> Task :spotlessCheck UP-TO-DATE
Failed build for 1ee2461
spotless check
> Task :spotlessCheck UP-TO-DATE
Failed build for 1ee2461
spotless check
> Task :spotlessCheck UP-TO-DATE
Failed build for ef37197
spotless check
> Task :spotlessCheck UP-TO-DATE
Failed build for ef37197
spotless check
> Task :spotlessCheck UP-TO-DATE
Failed build for 35ec6b8
spotless check
> Task :spotlessCheck UP-TO-DATE
Failed build for 35ec6b8
spotless check
> Task :spotlessCheck UP-TO-DATE

This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

@gagankumre

Copy link
Copy Markdown
Author

Hello @atm1504 please have a look upon this PR. This is my first PR at this org. Some checks have been unsuccessful.

@Abhik1998

Copy link
Copy Markdown

/assign @atm1504

@gagankumre
gagankumre requested a review from atm1504 January 27, 2020 10:06
login and signup button get enable and disable according to the input of credentials
@gagankumre gagankumre changed the title Login and signup button enabe/disable fix: #2435 Login and signup button enabe/disable Jan 27, 2020
@auto-label auto-label Bot added the fix label Jan 27, 2020
@gagankumre

Copy link
Copy Markdown
Author

@atm1504 can you please have a look over this error as I am unable to fix this ci test failure

@angmas1

angmas1 commented Feb 14, 2020

Copy link
Copy Markdown

run gradlew spotlessApply

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ui improvement for login and sign up page

4 participants