Skip to content
This repository was archived by the owner on May 21, 2026. It is now read-only.

feat: Implement recaptcha verification - #2349

Open
atm1504 wants to merge 12 commits into
fossasia:developmentfrom
atm1504:atm_login_recaptcha
Open

feat: Implement recaptcha verification#2349
atm1504 wants to merge 12 commits into
fossasia:developmentfrom
atm1504:atm_login_recaptcha

Conversation

@atm1504

@atm1504 atm1504 commented Aug 16, 2019

Copy link
Copy Markdown
Member

Fixes #2348 , #2319

Changes:

Screenshots for the change:
Will be updated once complete

@atm1504 atm1504 changed the title [WIP]: Implement recaptcha verification feat: Implement recaptcha verification Aug 19, 2019
@auto-label auto-label Bot added the feature label Aug 19, 2019
@atm1504

atm1504 commented Aug 21, 2019

Copy link
Copy Markdown
Member Author

@iamareebjamal should we have this feature. This was implemented as discussed in the Gitter channel, regarding the changes in the server-side script.
But, @liveHarshit shared some comments fossasia/open-event-attendee-android#1943 (comment) where it was discussed that ReCaptcha won't be needed in the android clients. Can you please confirm what should I do?

@iamareebjamal

Copy link
Copy Markdown
Member

Discuss this with SUSI server guys

@atm1504

atm1504 commented Aug 22, 2019

Copy link
Copy Markdown
Member Author

Discuss this with SUSI server guys

We had a discussion regarding this in the gitter channel, they said to implement recaptcha.

@atm1504

atm1504 commented Aug 23, 2019

Copy link
Copy Markdown
Member Author

@iamareebjamal please review it. Also, please tell where to store the API key.

@ci-reporter

ci-reporter Bot commented Aug 24, 2019

Copy link
Copy Markdown

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 3ff7a72. Here's the output:

lint check
> Task :app:preBuild UP-TO-DATE

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!


Failed build for de75047
lint check
> Task :app:preBuild UP-TO-DATE
Failed build for 21ed178
lint check
> Task :app:preBuild UP-TO-DATE

This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

@ci-reporter

ci-reporter Bot commented Aug 24, 2019

Copy link
Copy Markdown

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 21ed178. Here's the output:

lint check
> Task :app:preBuild UP-TO-DATE

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!


This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

@mariobehling

Copy link
Copy Markdown
Member

Please fix Travis.

@mariobehling

Copy link
Copy Markdown
Member

Please provide a screenshot.

@mariobehling mariobehling left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as in the other PR: We cannot keep the API key in the app itself. This would be a security issue. It should be added during building of the app using Travis environment variables. Please implement it in that way.

@atm1504 atm1504 mentioned this pull request Sep 19, 2019
@mkmar01

mkmar01 commented Feb 7, 2020

Copy link
Copy Markdown
Member

@atm1504 please refer to the way youtube API key is stored in the App.

@mkmar01

mkmar01 commented Feb 7, 2020

Copy link
Copy Markdown
Member

This PR is open for a long time, if anyone wants to take this up, they can

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ReCaptcha for second login attempt

4 participants