fix: select previous item correctly when deleting from 2-item collection#1714
Open
Manasvibansal1 wants to merge 1 commit into
Open
fix: select previous item correctly when deleting from 2-item collection#1714Manasvibansal1 wants to merge 1 commit into
Manasvibansal1 wants to merge 1 commit into
Conversation
Author
|
Hi, I've opened a PR with the fix , replacing itemIds.length > 1 with idx > 0 to mirror the removeEnvironment logic. PR: #1714 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
When exactly 2 requests exist and the non-first one is deleted,
itemIds.length > 1evaluates to false (1 item remains), sonewIdfalls through to null leaving the main panel blank even though one
request still exists.
Fix: Replace
itemIds.length > 1withidx > 0, mirroring theexisting
removeEnvironmentlogic.Related Issues
Checklist
mainbranch before making this PRflutter upgradeand verify)flutter test) and all tests are passingAdded/updated tests?
We encourage you to add relevant test cases.
OS on which you have developed and tested the feature?