Skip to content

fix: guard null content in saveToDownloads to prevent null-check crash (#1704) #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
deepak0x wants to merge 1 commit into from
+34 −11
Closed

fix: guard null content in saveToDownloads to prevent null-check crash (#1704) #1708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions lib/utils/save_utils.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,18 +31,19 @@ Future<void> saveToDownloads(
String? name,
}) async {
var message = "";
var path = await getFileDownloadpath(
name,
ext ?? getFileExtension(mimeType),
);
var path = await getFileDownloadpath(name, ext ?? getFileExtension(mimeType));
if (path != null) {
try {
await saveFile(path, content!);
var sp = getShortPath(path);
message = 'Saved to $sp';
} catch (e) {
debugPrint("$e");
message = "An error occurred while saving file.";
if (content == null) {
message = "No content available to save.";
} else {
try {
await saveFile(path, content);
var sp = getShortPath(path);
message = 'Saved to $sp';
} catch (e) {
debugPrint("$e");
message = "An error occurred while saving file.";
}
}
} else {
message = "Unable to determine the download path.";
Expand Down
22 changes: 22 additions & 0 deletions test/utils/save_utils_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,28 @@ void main() {
expect(find.byType(SnackBar), findsOneWidget);
});

testWidgets('saveToDownloads handles null content without crashing', (
tester,
) async {
final scaffoldKey = GlobalKey<ScaffoldMessengerState>();
await tester.pumpWidget(
MaterialApp(
scaffoldMessengerKey: scaffoldKey,
home: Scaffold(body: Container()),
),
);

final sm = scaffoldKey.currentState!;

await tester.runAsync(() async {
await saveToDownloads(sm, content: null, mimeType: 'text/plain');
});

// Wait for snackbar to appear
await tester.pump();
expect(find.byType(SnackBar), findsOneWidget);
});

testWidgets('saveAndShowDialog executes', (tester) async {
await tester.pumpWidget(
MaterialApp(
Expand Down