fix: handle empty CSV data and empty collection on startup#1677
Open
nazifsco wants to merge 1 commit into
Open
fix: handle empty CSV data and empty collection on startup#1677nazifsco wants to merge 1 commit into
nazifsco wants to merge 1 commit into
Conversation
- CsvPreviewer: return errorWidget when csvData is empty instead of crashing with RangeError on csvData[0] (fixes foss42#1647) - CollectionStateNotifier: guard requestSequenceProvider access so selectedId is null when collection is empty instead of crashing on first launch or after clearing all requests (fixes foss42#1640)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two RangeError crashes:
Fix 1 -- CsvPreviewer crashes on empty CSV response (closes #1647)
lib/widgets/previewer_csv.dartaccessedcsvData[0]without checking if the list was empty. Any API response returning empty or malformed CSV would crash the app.Fix 2 -- CollectionStateNotifier crashes on empty collection (closes #1640)
lib/providers/collection_providers.dartaccessedrequestSequenceProvider[0]unconditionally. On first launch or after clearing all requests, this crashed withRangeError: Index out of range.