Skip to content

fix: treat Accepted status as complete to suppress draft banner#982

Merged
romanetar merged 1 commit into
masterfrom
fix/save-incomplete-submissions
Jun 16, 2026
Merged

fix: treat Accepted status as complete to suppress draft banner#982
romanetar merged 1 commit into
masterfrom
fix/save-incomplete-submissions

Conversation

@romanetar

@romanetar romanetar commented Jun 16, 2026

Copy link
Copy Markdown

ref https://app.clickup.com/t/9014802374/86ba3xg57

Summary by CodeRabbit

  • Bug Fixes
    • Improved event completion detection. The system now accurately recognizes when events are complete in a wider range of scenarios, enhancing the reliability of event status tracking. This update ensures that events reaching completion are properly identified across different status conditions, providing more consistent and accurate event progress monitoring throughout the application.

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c6ade421-fc9a-4446-b98f-1a2190034aa3

📥 Commits

Reviewing files that changed from the base of the PR and between d8b41d4 and 458d855.

📒 Files selected for processing (1)
  • src/components/forms/event-form.js

📝 Walkthrough

Walkthrough

The isComplete() method in event-form.js has its completion condition expanded to accept entity.status of either "Accepted" or "Received" (previously only "Received") when entity.progress equals "COMPLETE".

Changes

Completion Status Check Update

Layer / File(s) Summary
isComplete() status condition broadened
src/components/forms/event-form.js
The status equality check against "Received" is replaced with an array inclusion check ["Accepted", "Received"], so events with "Accepted" status and "COMPLETE" progress are also considered complete.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 A hop and a skip through the code so neat,
Two statuses now mark an event complete!
"Accepted" joins "Received" in the check,
No more edge cases left on the deck.
The bunny approves — what a wonderful feat! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: treating 'Accepted' status as complete to suppress the draft banner, which aligns with the code modification that broadens the completion condition to include 'Accepted' status.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/save-incomplete-submissions

Comment @coderabbitai help to get the list of available commands and usage tips.

@romanetar romanetar merged commit da7128b into master Jun 16, 2026
9 checks passed
@romanetar romanetar deleted the fix/save-incomplete-submissions branch June 16, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant