fix: do not skip strokes when using the eraser - #1817
Draft
Doublonmousse wants to merge 3 commits into
Draft
Conversation
By advancing the seed by the number of segment, thus keeping the same appearance when splitting parts of the stroke
…aser position - if we have both current and previous position, construct a polygon of current and previous eraser bounds, take the convex hull - use the convex hull for intersection tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1247
For now I take the convex hull of the polygon containing both current and previous eraser bounds (we probably can do one helper function for this or compute a closed form hull for this case, if speed is a concern) and use it to do intersection tests with
geo(or use the previous code for the first down eraser event)With another fix related to #730 to keep the visual appearance of splitted textured strokes (nothing on the performance side though)