Skip to content

fix: surface catalog ID in PromptBuilder #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gspencergoog wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: surface catalog ID in PromptBuilder #919

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
133685f
fix: surface catalog ID in PromptBuilder
gspencergoog May 14, 2026
061a5bc
fix: sanitize catalog ID and add tests for null case in PromptBuilder
gspencergoog May 14, 2026
ff3caa6
Fix lint
gspencergoog May 15, 2026
5d1502f
Fix formatting
gspencergoog May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/genui/lib/src/facade/prompt_builder.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,8 @@ final class _BasicPromptBuilder extends PromptBuilder {
final fragments = <String>[
...systemPromptFragments,
'Use the provided tools to respond to user using rich UI elements.',
if (catalog.catalogId != null)
'The active catalog ID is: "${catalog.catalogId}".',
Comment thread
gspencergoog marked this conversation as resolved.
Outdated
...technicalPossibilities.systemPromptFragment(),
...catalog.systemPromptFragments,
...allowedOperations.systemPromptFragments,
Expand Down
11 changes: 11 additions & 0 deletions packages/genui/test/facade/prompt_builder_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,4 +123,15 @@ void main() {
});
}
});

group('Catalog ID', () {
test('is surfaced in system prompt when provided', () {
final catalog = Catalog([
BasicCatalogItems.text,
], catalogId: 'my_custom_catalog');
final builder = PromptBuilder.chat(catalog: catalog);
final String prompt = builder.systemPromptJoined();
expect(prompt, contains('The active catalog ID is: "my_custom_catalog"'));
});
});
}
Comment thread
gspencergoog marked this conversation as resolved.
4 changes: 4 additions & 0 deletions ...ages/genui/test/facade/prompt_builder_test.golden/all_operations_with_dataModel_false.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ Use the provided tools to respond to user using rich UI elements.

-------------------------------------

The active catalog ID is: "test_catalog".

-------------------------------------

IMPORTANT: You do not have the ability to execute code. If you need to perform calculations, do them yourself.

-------------------------------------
Expand Down
4 changes: 4 additions & 0 deletions packages/genui/test/facade/prompt_builder_test.golden/all_operations_with_dataModel_true.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ Use the provided tools to respond to user using rich UI elements.

-------------------------------------

The active catalog ID is: "test_catalog".

-------------------------------------

IMPORTANT: You do not have the ability to execute code. If you need to perform calculations, do them yourself.

-------------------------------------
Expand Down
4 changes: 4 additions & 0 deletions ...s/genui/test/facade/prompt_builder_test.golden/create_and_update_with_dataModel_false.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ Use the provided tools to respond to user using rich UI elements.

-------------------------------------

The active catalog ID is: "test_catalog".

-------------------------------------

IMPORTANT: You do not have the ability to execute code. If you need to perform calculations, do them yourself.

-------------------------------------
Expand Down
4 changes: 4 additions & 0 deletions ...es/genui/test/facade/prompt_builder_test.golden/create_and_update_with_dataModel_true.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ Use the provided tools to respond to user using rich UI elements.

-------------------------------------

The active catalog ID is: "test_catalog".

-------------------------------------

IMPORTANT: You do not have the ability to execute code. If you need to perform calculations, do them yourself.

-------------------------------------
Expand Down
4 changes: 4 additions & 0 deletions packages/genui/test/facade/prompt_builder_test.golden/create_only_with_dataModel_false.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ Use the provided tools to respond to user using rich UI elements.

-------------------------------------

The active catalog ID is: "test_catalog".

-------------------------------------

IMPORTANT: You do not have the ability to execute code. If you need to perform calculations, do them yourself.

-------------------------------------
Expand Down
4 changes: 4 additions & 0 deletions packages/genui/test/facade/prompt_builder_test.golden/create_only_with_dataModel_true.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ Use the provided tools to respond to user using rich UI elements.

-------------------------------------

The active catalog ID is: "test_catalog".

-------------------------------------

IMPORTANT: You do not have the ability to execute code. If you need to perform calculations, do them yourself.

-------------------------------------
Expand Down
4 changes: 4 additions & 0 deletions packages/genui/test/facade/prompt_builder_test.golden/update_only_with_dataModel_false.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ Use the provided tools to respond to user using rich UI elements.

-------------------------------------

The active catalog ID is: "test_catalog".

-------------------------------------

IMPORTANT: You do not have the ability to execute code. If you need to perform calculations, do them yourself.

-------------------------------------
Expand Down
4 changes: 4 additions & 0 deletions packages/genui/test/facade/prompt_builder_test.golden/update_only_with_dataModel_true.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ Use the provided tools to respond to user using rich UI elements.

-------------------------------------

The active catalog ID is: "test_catalog".

-------------------------------------

IMPORTANT: You do not have the ability to execute code. If you need to perform calculations, do them yourself.

-------------------------------------
Expand Down
Loading