feat: select composer attachments#1259
Open
FromSi wants to merge 1 commit intofloatpane:masterfrom
Open
Conversation
floatpanebot
added
area/tui
andrinoff
requested changes
May 9, 2026
| @@ -472,8 +511,7 @@ func (m *Composer) Update(msg tea.Msg) (tea.Model, tea.Cmd) { | |||
|
|
|||
| case "backspace", "delete", "d": | |||
Member
There was a problem hiding this comment.
lets actually add a keybind to the composer struct. this should be configurable
Contributor
Author
There was a problem hiding this comment.
Which keybind is better?
"composer": {
"external_editor": "ctrl+e",
"next_field": "tab",
"prev_field": "shift+tab",
"suggestions_up": "ctrl+p",
"suggestions_down": "ctrl+n",
"suggestions_accept": "enter",
"suggestions_cancel": "esc",
"prompt_submit": "enter",
"prompt_cancel": "esc",
"account_up": "up",
"account_down": "down",
"account_select": "enter",
"account_cancel": "esc",
"discard_draft": "y",
"keep_draft": "n",
"attachment_up": "up",
"attachment_down": "down",
"attachment_remove": "d",
"activate": "enter",
"toggle": "space"
}OR
"composer": {
"external_editor": "ctrl+e",
"next_field": "tab",
"prev_field": "shift+tab",
"up": "k",
"down": "j",
"accept": "enter",
"cancel": "esc",
"toggle": "space",
"remove": "d",
"suggestions_up": "ctrl+p",
"suggestions_down": "ctrl+n",
"discard_draft": "y",
"keep_draft": "n"
}
Member
There was a problem hiding this comment.
no, i meant particularly delete, what are the other keybinds even?
Contributor
Author
There was a problem hiding this comment.
ctrl+e open external editor (already config: composer.external_editor)
tab next field (already config: composer.next_field)
shift+tab previous field (already config: composer.prev_field)
up move contact suggestion up
ctrl+p move contact suggestion up
down move contact suggestion down
ctrl+n move contact suggestion down
tab accept contact suggestion (already config fallback: composer.next_field)
enter accept contact suggestion
esc close contact suggestions
enter submit plugin prompt
esc cancel plugin prompt
up move account picker up
k move account picker up
down move account picker down
j move account picker down
enter select account
esc close account picker
y discard draft
Y discard draft
n keep draft
N keep draft
esc keep draft / cancel exit confirmation (already config: global.cancel)
up move attachment selection up
global nav_up move attachment selection up (already config: global.nav_up)
down move attachment selection down
global nav_down move attachment selection down (already config: global.nav_down)
backspace remove selected attachment
delete remove selected attachment
d remove selected attachment
enter open account picker / add attachment / toggle S/MIME / send
space edit catch-all From / toggle S/MIME
ctrl+c quit (already config: global.quit)
esc start exit confirmation (already config: global.cancel)
Member
There was a problem hiding this comment.
just add 1 for the attachments delete, if any require latter changes, it will be a separate PR and, please @ me, because I do not receive github notifications from review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Added selectable attachment navigation in the composer. Attachments are now shown as a focused list with a cursor, and
backspace,delete, ordremoves the selected attachment instead of always removing the last one.Why?
Previously, when multiple files were attached, the composer only allowed removing the most recently added attachment. This makes it possible to choose and remove any specific attachment without deleting newer ones first.
Closes #543