Skip to content

fix(config): cache read no mutation #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mvanhorn wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

fix(config): cache read no mutation #1256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions config/cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,15 +495,15 @@ func saveEmailBodyCache(cache *EmailBodyCache) error {
}

// GetCachedEmailBody returns the cached body for a specific email, or nil if not cached.
// LastAccessedAt is updated by SaveEmailBody, not here -- a read should not
// mutate cache state.
func GetCachedEmailBody(folderName string, uid uint32, accountID string) *CachedEmailBody {
cache, err := LoadEmailBodyCache(folderName)
if err != nil {
return nil
}
for i, b := range cache.Bodies {
if b.UID == uid && b.AccountID == accountID {
cache.Bodies[i].LastAccessedAt = time.Now()
_ = saveEmailBodyCache(cache)
return &cache.Bodies[i]
}
}
Expand Down
Loading