Skip to content

[2.x] fix: allow boolean settings with truthy defaults to be disabled #4782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huoxin233 wants to merge 1 commit into
base: 2.x
Choose a base branch
from
+1 −1
Open

[2.x] fix: allow boolean settings with truthy defaults to be disabled #4782

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion framework/core/js/src/admin/components/AdminPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ export default abstract class AdminPage<CustomAttrs extends IPageAttrs = IPageAt
* with the setting key, which is used by `resetButton()` in the reset modal.
*/
setting(key: string, fallback: string = '', label?: Mithril.Children): Stream<string> {
this.settings[key] = this.settings[key] || Stream<string>(app.data.settings[key] || fallback);
this.settings[key] = this.settings[key] || Stream<string>(app.data.settings[key] ?? fallback);

if (label !== undefined) {
this.settingLabels[key] = label;
Expand Down
Loading