Proof of concept of optimized Set#4
Draft
applejag wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is merely a suggestion. If you want to see this added then I'll override the
Setimplementation with theSet2implementation.Removes the need for allocating when adding new entries to the set. Still needs an allocation when the slice grows, but that can also be fixed by setting a big enough capacity on boot. Could even get rid of
appendand tracking the length manually, which would only allow a maximum of X number of projectiles at a time. But that's a realistic tradeoff.The design of
.iter()returning[]boolis intended to prevent the user to try use a copy of the items from theitemsslice, and to avoid having to copy bigger structs back and forth. The "structs of arrays" pattern also produces better struct field padding, but I don't know if that matters in the WASM runtime that Firefly uses.