Add deploy Dart on Firebase Functions codelab sample#1277
Add deploy Dart on Firebase Functions codelab sample#1277jhuleatt wants to merge 5 commits intodart-launchfrom
Conversation
This commit implements the Dart Firebase Functions codelab logic. It creates a Dart/codelab-dart-functions flutter application with an additional shared package for sharing the `IncrementResponse` object via json\_serializable between front-end and back-end logic. Additionally it implements the `incrementCallable` functionality via a new google\_cloud\_firestore and firebase\_functions dart application project that compiles and targets node correctly through firebase deploy. Co-authored-by: jhuleatt <3759507+jhuleatt@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements a multiplayer counter application using Flutter and Dart-based Firebase Functions, supported by a shared package for data models. The review feedback identifies a critical type-casting error in the server's query parameter handling and a potential race condition where the returned counter value may be stale. Furthermore, the reviewer suggests improving error handling for unsupported HTTP methods and cleaning up unused boilerplate code and placeholder documentation in the shared package.
| // TODO: Put public facing types in this file. | ||
|
|
||
| /// Checks if you are awesome. Spoiler: you are. | ||
| class Awesome { | ||
| bool get isAwesome => true; | ||
| } |
There was a problem hiding this comment.
This file appears to be boilerplate code from a package template and is not used in the project. It should be removed to maintain a clean codebase.
| TODO: Put a short description of the package here that helps potential users | ||
| know whether this package might be useful for them. | ||
|
|
||
| ## Features | ||
|
|
||
| TODO: List what your package can do. Maybe include images, gifs, or videos. | ||
|
|
||
| ## Getting started | ||
|
|
||
| TODO: List prerequisites and provide or point to information on how to | ||
| start using the package. | ||
|
|
||
| ## Usage | ||
|
|
||
| TODO: Include short and useful examples for package users. Add longer examples | ||
| to `/example` folder. | ||
|
|
||
| ```dart | ||
| const like = 'sample'; | ||
| ``` | ||
|
|
||
| ## Additional information | ||
|
|
||
| TODO: Tell users more about the package: where to find more information, how to | ||
| contribute to the package, how to file issues, what response they can expect | ||
| from the package authors, and more. |
There was a problem hiding this comment.
The README for the shared package contains numerous 'TODO' placeholders. These should be replaced with actual documentation describing the package's purpose and usage before the code is merged.
This commit implements the Dart Firebase Functions codelab logic. It creates a Dart/codelab-dart-functions flutter application with an additional shared package for sharing the `IncrementResponse` object via json\_serializable between front-end and back-end logic. Additionally it implements the `incrementCallable` functionality via a new google\_cloud\_firestore and firebase\_functions dart application project that compiles and targets node correctly through firebase deploy. Co-authored-by: jhuleatt <3759507+jhuleatt@users.noreply.github.com>
The dart setup action only configures `dart`, not `flutter`. Therefore when `dart pub get` is run in the root of the flutter app, it fails. We check the pubspec.yaml for the flutter sdk marker and skip those directories since flutter tests cannot run via just the dart SDK on CI. Co-authored-by: jhuleatt <3759507+jhuleatt@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This commit implements the Dart Firebase Functions codelab logic. It creates a Dart/codelab-dart-functions flutter application with an additional shared package for sharing the `IncrementResponse` object via json\_serializable between front-end and back-end logic. Additionally it implements the `incrementCallable` functionality via a new google\_cloud\_firestore and firebase\_functions dart application project that compiles and targets node correctly through firebase deploy. This also includes a fix for dart CI to not attempt to test flutter projects, as only dart sdk is available there. Co-authored-by: jhuleatt <3759507+jhuleatt@users.noreply.github.com>
2 participants
Adds a complete working implementation of the official "Deploy Dart on Firebase Functions" codelab inside the Dart repository under
Dart/codelab-dart-functions. The setup avoids large auto-generated mobile project folders in the tree and features a cleanly abstracted data model package for true fullstack type safety with dart.PR created automatically by Jules for task 4853368971760704869 started by @jhuleatt