Skip to content

build(deps): bump all package and workflow dependencies#1392

Open
mikehardy wants to merge 1 commit into
test/e2e-playwright-designfrom
chore/deps-bump-all
Open

build(deps): bump all package and workflow dependencies#1392
mikehardy wants to merge 1 commit into
test/e2e-playwright-designfrom
chore/deps-bump-all

Conversation

@mikehardy

@mikehardy mikehardy commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Merge path

Targets test/e2e-playwright-design (single commit). Retarget to main after the e2e PR lands — this should merge to main only once e2e is on main.

Summary

  • Bump pnpm catalog, workspace package.json files, lockfile, and CI workflows to current stable versions (pnpm 11, Node 24.18.0, Next 16, Vite 8, Vitest 4, React 19.2, ESLint 9, etc.).
  • Pin workflow actions to SHAs (inherits e2e base); update firebase-tools in CI.
  • Fix fallout: Vitest 4 constructor mocks, jsdom localStorage setup, TanStack Form error assertions, ESLint 9 cap (angular-eslint), react-hooks/refs lint fixes.
  • Document Firebase JS SDK version policy in AD-9 — catalog stays on v11 for @angular/fire; peers allow v12 for consumers; optional split strategy described there.

Firebase policy (read before reviewing version choices): AD-9 in decisions.md

Intentionally not bumped (see AD-9 / PR discussion): ESLint 10 (angular-eslint peer), catalog Firebase 12 (@angular/fire@20), TypeScript 6 (tsup DTS), Angular 22 (@angular/fire peer).

Test plan

  • pnpm install
  • pnpm build
  • pnpm test
  • pnpm lint:check
  • pnpm test:e2e (CI on this PR)

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the workspace to Node.js v24 and pnpm v11, updates numerous dependencies across the monorepo via the pnpm catalog, and documents the Firebase JS SDK version policy (AD-9). It also addresses compatibility issues with jsdom 29 and Node 26 by adding a custom localStorage mock in the core test setup, refactors various test mocks, and wraps ref assignments in useEffect hooks in React forms. Feedback is provided to improve the custom localStorage mock in the test setup to fully implement the standard Storage interface by adding the length property and key() method.

Comment thread packages/core/src/tests/setup.ts Outdated
@mikehardy mikehardy force-pushed the chore/deps-bump-all branch from 289a7ce to 1bd4287 Compare July 3, 2026 21:49
@wiz-9635d3485b

wiz-9635d3485b Bot commented Jul 3, 2026

Copy link
Copy Markdown

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities -
Data Finding Sensitive Data -
Secret Finding Secrets -
IaC Misconfiguration IaC Misconfigurations -
SAST Finding SAST Findings 2 Low
Software Management Finding Software Management Findings -
Total 2 Low

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant