build(deps): bump all package and workflow dependencies#1392
Open
mikehardy wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request upgrades the workspace to Node.js v24 and pnpm v11, updates numerous dependencies across the monorepo via the pnpm catalog, and documents the Firebase JS SDK version policy (AD-9). It also addresses compatibility issues with jsdom 29 and Node 26 by adding a custom localStorage mock in the core test setup, refactors various test mocks, and wraps ref assignments in useEffect hooks in React forms. Feedback is provided to improve the custom localStorage mock in the test setup to fully implement the standard Storage interface by adding the length property and key() method.
289a7ce to
1bd4287
Compare
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge path
Targets
test/e2e-playwright-design(single commit). Retarget tomainafter the e2e PR lands — this should merge tomainonly once e2e is onmain.Summary
package.jsonfiles, lockfile, and CI workflows to current stable versions (pnpm 11, Node 24.18.0, Next 16, Vite 8, Vitest 4, React 19.2, ESLint 9, etc.).firebase-toolsin CI.angular-eslint), react-hooks/refs lint fixes.@angular/fire; peers allow v12 for consumers; optional split strategy described there.Firebase policy (read before reviewing version choices): AD-9 in decisions.md
Intentionally not bumped (see AD-9 / PR discussion): ESLint 10 (
angular-eslintpeer), catalog Firebase 12 (@angular/fire@20), TypeScript 6 (tsupDTS), Angular 22 (@angular/firepeer).Test plan
pnpm installpnpm buildpnpm testpnpm lint:checkpnpm test:e2e(CI on this PR)